-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LS fast-run to show compiler diagnostics and fail-fast on compilation errors #43735
Merged
NipunaRanasinghe
merged 7 commits into
ballerina-platform:master
from
NipunaRanasinghe:fast-run-improvements-master
Jan 9, 2025
Merged
Fix LS fast-run to show compiler diagnostics and fail-fast on compilation errors #43735
NipunaRanasinghe
merged 7 commits into
ballerina-platform:master
from
NipunaRanasinghe:fast-run-improvements-master
Jan 9, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NipunaRanasinghe
changed the title
Fix LS Fast-run to show compiler diagnostics and fail-fast on compilation errors
Fix LS fast-run to show compiler diagnostics and fail-fast on compilation errors
Jan 6, 2025
NipunaRanasinghe
requested review from
dulajdilshan,
LakshanWeerasinghe and
nipunayf
January 7, 2025 11:40
LakshanWeerasinghe
previously approved these changes
Jan 7, 2025
NipunaRanasinghe
requested review from
gimantha,
MaryamZi,
warunalakshitha and
azinneera
as code owners
January 8, 2025 03:59
NipunaRanasinghe
force-pushed
the
fast-run-improvements-master
branch
2 times, most recently
from
January 9, 2025 05:52
d700a21
to
bc12a96
Compare
NipunaRanasinghe
force-pushed
the
fast-run-improvements-master
branch
from
January 9, 2025 05:53
bc12a96
to
cbab642
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #43735 +/- ##
============================================
- Coverage 77.42% 77.41% -0.01%
- Complexity 58622 58626 +4
============================================
Files 3445 3446 +1
Lines 219172 219214 +42
Branches 28968 28973 +5
============================================
+ Hits 169690 169703 +13
- Misses 40052 40073 +21
- Partials 9430 9438 +8 ☔ View full report in Codecov by Sentry. |
dulajdilshan
approved these changes
Jan 9, 2025
LakshanWeerasinghe
approved these changes
Jan 9, 2025
NipunaRanasinghe
merged commit Jan 9, 2025
35de750
into
ballerina-platform:master
16 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject.
Fixes #43734
Approach
Samples
Remarks
Check List