Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LS fast-run to show compiler diagnostics and fail-fast on compilation errors #43735

Conversation

NipunaRanasinghe
Copy link
Contributor

Purpose

$subject.

Fixes #43734

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@NipunaRanasinghe NipunaRanasinghe changed the title Fix LS Fast-run to show compiler diagnostics and fail-fast on compilation errors Fix LS fast-run to show compiler diagnostics and fail-fast on compilation errors Jan 6, 2025
@NipunaRanasinghe NipunaRanasinghe force-pushed the fast-run-improvements-master branch 2 times, most recently from d700a21 to bc12a96 Compare January 9, 2025 05:52
@NipunaRanasinghe NipunaRanasinghe force-pushed the fast-run-improvements-master branch from bc12a96 to cbab642 Compare January 9, 2025 05:53
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 53.65854% with 19 lines in your changes missing coverage. Please review.

Project coverage is 77.41%. Comparing base (d8a9cfa) to head (cbab642).
Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
...angserver/workspace/BallerinaWorkspaceManager.java 57.89% 5 Missing and 3 partials ⚠️
...lang/langserver/command/executors/RunExecutor.java 56.25% 5 Missing and 2 partials ⚠️
...lerinalang/debugadapter/JBallerinaDebugServer.java 20.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #43735      +/-   ##
============================================
- Coverage     77.42%   77.41%   -0.01%     
- Complexity    58622    58626       +4     
============================================
  Files          3445     3446       +1     
  Lines        219172   219214      +42     
  Branches      28968    28973       +5     
============================================
+ Hits         169690   169703      +13     
- Misses        40052    40073      +21     
- Partials       9430     9438       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NipunaRanasinghe NipunaRanasinghe merged commit 35de750 into ballerina-platform:master Jan 9, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Compilation erros and warnings are not shown in fast-run mode
3 participants