Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debugger] Add support to launch programs in fast-run mode #43709

Conversation

NipunaRanasinghe
Copy link
Contributor

Purpose

$subject.

Resolves #43702.

Samples

Provide high-level details about the samples related to this feature.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@NipunaRanasinghe NipunaRanasinghe force-pushed the debugger-fast-run-support branch from a0875af to ec13a1d Compare December 16, 2024 09:26
@nipunayf nipunayf requested a review from Copilot December 16, 2024 13:25

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 12 changed files in this pull request and generated no comments.

Files not reviewed (7)
  • misc/debug-adapter/modules/debug-adapter-core/spotbugs-exclude.xml: Language not supported
  • language-server/modules/langserver-commons/src/main/java/org/ballerinalang/langserver/commons/workspace/RunContext.java: Evaluated as low risk
  • language-server/modules/langserver-commons/src/main/java/org/ballerinalang/langserver/commons/workspace/WorkspaceManager.java: Evaluated as low risk
  • language-server/modules/langserver-core/src/main/java/org/ballerinalang/langserver/command/executors/RunExecutor.java: Evaluated as low risk
  • tests/jballerina-debugger-integration-test/src/test/java/org/ballerinalang/debugger/test/adapter/DebugOutputTest.java: Evaluated as low risk
  • misc/debug-adapter/modules/debug-adapter-core/src/main/java/org/ballerinalang/debugadapter/DebugOutputLogger.java: Evaluated as low risk
  • language-server/modules/langserver-core/src/main/java/org/ballerinalang/langserver/workspace/BallerinaWorkspaceManager.java: Evaluated as low risk
Comments suppressed due to low confidence (1)

misc/debug-adapter/modules/debug-adapter-core/src/main/java/org/ballerinalang/debugadapter/JBallerinaDebugServer.java:299

  • The parameter name portName should be renamed to port for consistency.
private void attachToRemoteVM(String hostName, int portName) throws IOException,
nipunayf
nipunayf previously approved these changes Dec 16, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 53.15315% with 104 lines in your changes missing coverage. Please review.

Project coverage is 77.39%. Comparing base (0c56743) to head (f0008ac).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
...lerinalang/debugadapter/JBallerinaDebugServer.java 30.76% 35 Missing and 1 partial ⚠️
...lang/langserver/command/executors/RunExecutor.java 58.18% 22 Missing and 1 partial ⚠️
...angserver/workspace/BallerinaWorkspaceManager.java 59.09% 13 Missing and 5 partials ⚠️
.../ballerinalang/debugadapter/utils/ServerUtils.java 25.00% 17 Missing and 1 partial ⚠️
...lerinalang/debugadapter/DebugExecutionManager.java 78.26% 3 Missing and 2 partials ⚠️
...nalang/debugadapter/config/ClientConfigHolder.java 60.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #43709      +/-   ##
============================================
- Coverage     77.40%   77.39%   -0.01%     
- Complexity    58600    58622      +22     
============================================
  Files          3446     3447       +1     
  Lines        219114   219242     +128     
  Branches      28965    28971       +6     
============================================
+ Hits         169604   169693      +89     
- Misses        40080    40118      +38     
- Partials       9430     9431       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NipunaRanasinghe NipunaRanasinghe merged commit 41cde72 into ballerina-platform:master Dec 17, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Integrate "fast-run" support to the debug server
2 participants