Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Implement semtype for type system in Ballerina #43685

Open
wants to merge 1,005 commits into
base: master
Choose a base branch
from
Open

[master] Implement semtype for type system in Ballerina #43685

wants to merge 1,005 commits into from

Conversation

gimantha
Copy link
Contributor

@gimantha gimantha commented Dec 4, 2024

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes #40474

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

lochana-chathura and others added 30 commits November 19, 2024 13:25
@lochana-chathura
Refactor BTypedescType
4b78b5d
@lochana-chathura
Refactor BTableType and BFutureType
14bb02b
@lochana-chathura
Refactor type env usages
af54e9d
@lochana-chathura
Refactor BErrorType type
0543cd7
@lochana-chathura
Fix checkstyle issues
0ed0a1b
@lochana-chathura
Make env variable in few BTypes private
6f99ac2
@lochana-chathura
Fix failure due to tSymbols
8cfbb5b
@lochana-chathura
Refactor BUnionType type
3a6c1b0
@lochana-chathura
Refactor BJSONType semtype resolution
97bd5c4
@lochana-chathura
Refactor BAnydataType semtype resolution
b38c20b
@heshanpadmasiri
Implement scaffolding
7b1c4a2
@heshanpadmasiri
Port never type
5c6ad82
@heshanpadmasiri
Port nil type
f6f8aae 
Avoid repeated type creation
@heshanpadmasiri
Port Decimal type
fa86d30
@heshanpadmasiri
Port float type
f1c9244
@heshanpadmasiri
Refactor caches to use DATs
04592f4
@heshanpadmasiri
Port int type
24cee8b 
Cache int singleton creation
@heshanpadmasiri
Port Boolean type
c1cd84f
@heshanpadmasiri
Port String type
056427c
@lochana-chathura
Merge pull request #43583 from lochana-chathura/semIntegration/direct…
802f909 
…_resolve

Refactor semtype creation
@heshanpadmasiri
Refactor SemType implementation
41416cb
@heshanpadmasiri
Add doc comments
23f02a1
@heshanpadmasiri
Fix float equality
9c204b1
@heshanpadmasiri
Refactor type tests
7af9767 
Use new api in CompilerTypeTestApi

Extract out the which semtype implementation used for tests

Implement semtype tests
@heshanpadmasiri
Add runtime type tests provider
fa2de32
@heshanpadmasiri
Add more basic type tests
ca0f47b
@heshanpadmasiri
Fix compile time type bugs
730ca2f
@heshanpadmasiri
Refactor type resolvers
a7a5628 
Fix doc comments
@heshanpadmasiri
Add runtime type tests provider
8763e85
@heshanpadmasiri
Make it possible to create cell type
74ba9d3
@gimantha gimantha added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label Dec 4, 2024
@gimantha gimantha changed the title [master] Implement semtype for tyep system in Ballerina [master] Implement semtype for type system in Ballerina Dec 4, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
3.0% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lochana-chathura lochana-chathura lochana-chathura left review comments

@MaryamZi MaryamZi Awaiting requested review from MaryamZi MaryamZi is a code owner

@KavinduZoysa KavinduZoysa Awaiting requested review from KavinduZoysa KavinduZoysa is a code owner

@warunalakshitha warunalakshitha Awaiting requested review from warunalakshitha warunalakshitha is a code owner

@azinneera azinneera Awaiting requested review from azinneera azinneera is a code owner

@keizer619 keizer619 Awaiting requested review from keizer619 keizer619 is a code owner

@NipunaRanasinghe NipunaRanasinghe Awaiting requested review from NipunaRanasinghe NipunaRanasinghe is a code owner

@sameerajayasoma sameerajayasoma Awaiting requested review from sameerajayasoma sameerajayasoma is a code owner

@hasithaa hasithaa Awaiting requested review from hasithaa hasithaa is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement]: Integrate nBallerina type engine into jBallerina