Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "proxy script" to be able to run bal in Windows Git Bash #43481

Merged

Conversation

Shadow-Devil
Copy link
Contributor

Purpose

When running bal inside Windows Git Bash the command is not found. This PR adds a "proxy script" that will execute the bal.bat file in Git Bash.

Fixes #13448

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (installer-fix@f392e37). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             installer-fix   #43481   +/-   ##
================================================
  Coverage                 ?   77.55%           
  Complexity               ?    58732           
================================================
  Files                    ?     3447           
  Lines                    ?   219716           
  Branches                 ?    28943           
================================================
  Hits                     ?   170395           
  Misses                   ?    39899           
  Partials                 ?     9422           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keizer619 keizer619 changed the base branch from master to installer-fix November 16, 2024 01:37
@@ -0,0 +1 @@
cmd "bal.bat"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shadow-Devil do this change here?
https://github.com/ballerina-platform/ballerina-update-tool/tree/master/resources/bin

because bin/bal has the content from update tool (which is from above location) and things in the ballerina-lang are being packed inside distributions/bin

'bin/bal' calls the distributions/bin/bal by checking the command

@keizer619 keizer619 merged commit 27b6cda into ballerina-platform:installer-fix Nov 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ballerina CLI as .bat file only cause command not found using Git Bash
2 participants