Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dead code elimination #43112

Conversation

heshanpadmasiri
Copy link
Member

@heshanpadmasiri heshanpadmasiri commented Jul 17, 2024

Purpose

Merge the optimization in #43013 with master

Fixes #43111

Approach

For a detailed explanation please checkout the original PR (#43013)

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 80.68783% with 292 lines in your changes missing coverage. Please review.

Project coverage is 77.57%. Comparing base (66f7b52) to head (f94714b).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
.../java/io/ballerina/projects/JBallerinaBackend.java 79.83% 31 Missing and 17 partials ⚠️
...ava/io/ballerina/projects/UsedBIRNodeAnalyzer.java 86.76% 16 Missing and 27 partials ⚠️
...wso2/ballerinalang/compiler/bir/model/BIRNode.java 52.83% 20 Missing and 5 partials ⚠️
...c/main/java/io/ballerina/projects/JarResolver.java 61.29% 14 Missing and 10 partials ⚠️
.../compiler/semantics/model/SimpleBTypeAnalyzer.java 77.01% 19 Missing and 1 partial ⚠️
...lerina/projects/util/CodegenOptimizationUtils.java 66.66% 8 Missing and 7 partials ⚠️
...java/org/ballerinalang/compiler/CompilerPhase.java 8.33% 10 Missing and 1 partial ⚠️
...n/bytecodeoptimizer/NativeDependencyOptimizer.java 88.65% 4 Missing and 7 partials ⚠️
...ir/codegen/bytecodeoptimizer/ClassNodeVisitor.java 77.27% 8 Missing and 2 partials ⚠️
...ina/projects/DeadCodeEliminationReportEmitter.java 87.83% 8 Missing and 1 partial ⚠️
... and 28 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #43112      +/-   ##
============================================
+ Coverage     77.55%   77.57%   +0.01%     
- Complexity    58722    59141     +419     
============================================
  Files          3447     3465      +18     
  Lines        219658   221084    +1426     
  Branches      28915    29101     +186     
============================================
+ Hits         170365   171499    +1134     
- Misses        39892    40093     +201     
- Partials       9401     9492      +91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hasithaa
hasithaa previously approved these changes Jul 24, 2024
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Aug 29, 2024
@heshanpadmasiri heshanpadmasiri force-pushed the feature-codegen-optimizer branch 8 times, most recently from fcbd5ed to d482280 Compare September 16, 2024 03:11
@heshanpadmasiri heshanpadmasiri force-pushed the feature-codegen-optimizer branch from 1456c4f to f94714b Compare October 30, 2024 09:11
@heshanpadmasiri
Copy link
Member Author

heshanpadmasiri commented Nov 8, 2024

Closed in favor of #43560

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Implement dead code elimination
3 participants