-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java 21] Support ballerina lang to build with Java 21 #43087
[Java 21] Support ballerina lang to build with Java 21 #43087
Conversation
We need to revisit spotbugs exclude for lang repository as a separate task later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we add the java21
branch to the PR build workflows?
Added ubuntu and windows build. Full build pipeline will fail without stdlib migration. We can add that later. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## java21 #43087 +/- ##
============================================
- Coverage 77.32% 77.31% -0.01%
+ Complexity 58537 58532 -5
============================================
Files 3460 3460
Lines 220048 220050 +2
Branches 28902 28902
============================================
- Hits 170144 170133 -11
- Misses 40491 40514 +23
+ Partials 9413 9403 -10 ☔ View full report in Codecov by Sentry. |
84f2021
to
c8c9b1e
Compare
.../testerina-runtime/src/main/java/org/ballerinalang/test/runtime/util/TesterinaConstants.java
Outdated
Show resolved
Hide resolved
project-api/project-api-test/src/test/java/io/ballerina/projects/test/TestBalaWriter.java
Outdated
Show resolved
Hide resolved
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
e0b19fe
to
c965c08
Compare
cli/ballerina-cli/src/test/resources/test-resources/tool-gayals/target-dir/.DS_Store
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the comment added LGTM
Purpose
Fixes #43119
Fixes #43146
Check List