Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java 21] Support ballerina lang to build with Java 21 #43087

Merged

Conversation

warunalakshitha
Copy link
Contributor

@warunalakshitha warunalakshitha commented Jul 12, 2024

Purpose

Fixes #43119
Fixes #43146

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@warunalakshitha
Copy link
Contributor Author

We need to revisit spotbugs exclude for lang repository as a separate task later.

Copy link
Contributor

@HindujaB HindujaB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add the java21 branch to the PR build workflows?

@warunalakshitha
Copy link
Contributor Author

Shall we add the java21 branch to the PR build workflows?

Added ubuntu and windows build. Full build pipeline will fail without stdlib migration. We can add that later.

@warunalakshitha warunalakshitha requested review from azinneera, gayaldassanayake, gabilang and ShammiL and removed request for hevayo and mohanvive July 19, 2024 10:45
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.31%. Comparing base (1ffa817) to head (8f6d65d).
Report is 36 commits behind head on java21.

Files with missing lines Patch % Lines
...rc/main/java/io/ballerina/cli/cmd/CommandUtil.java 0.00% 1 Missing ⚠️
...rc/main/java/io/ballerina/cli/cmd/PushCommand.java 0.00% 1 Missing ⚠️
...debugadapter/evaluation/utils/EvaluationUtils.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             java21   #43087      +/-   ##
============================================
- Coverage     77.32%   77.31%   -0.01%     
+ Complexity    58537    58532       -5     
============================================
  Files          3460     3460              
  Lines        220048   220050       +2     
  Branches      28902    28902              
============================================
- Hits         170144   170133      -11     
- Misses        40491    40514      +23     
+ Partials       9413     9403      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Aug 10, 2024
@HindujaB HindujaB removed the Stale label Aug 14, 2024
@HindujaB HindujaB force-pushed the java21_initial_configs branch from e0b19fe to c965c08 Compare August 21, 2024 04:14
Copy link
Contributor

@gayaldassanayake gayaldassanayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comment added LGTM

@HindujaB HindujaB merged commit 9806c01 into ballerina-platform:java21 Sep 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants