Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add runtime APIs for runtime management module #42414

Merged
merged 19 commits into from
Apr 3, 2024
Merged

Add runtime APIs for runtime management module #42414

merged 19 commits into from
Apr 3, 2024

Conversation

HindujaB
Copy link
Contributor

@HindujaB HindujaB commented Mar 26, 2024 •
edited
Loading

Purpose

$subject
Fixes #42406

Approach

TODO:

  • check return object structure with module requirement
  • multiple services with the same listener
  • service name representation
  • add annotations
  • check compiler opttions

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@HindujaB HindujaB marked this pull request as draft March 26, 2024 11:59
@HindujaB HindujaB added the Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime label Mar 27, 2024
@HindujaB HindujaB requested a review from gabilang March 27, 2024 15:05
@HindujaB HindujaB marked this pull request as ready for review March 27, 2024 15:05
@HindujaB HindujaB changed the title [WIP] Add runtime APIs for runtime management module Add runtime APIs for runtime management module Mar 27, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.91209% with 11 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (runtime-mgt@7b69c3e). Click here to learn what that means.

Files Patch % Lines
.../io/ballerina/runtime/internal/RepositoryImpl.java 83.92% 7 Missing and 2 partials ⚠️
.../compiler/bir/codegen/methodgen/MainMethodGen.java 85.71% 0 Missing and 1 partial ⚠️
...ompiler/bir/codegen/split/values/JvmObjectGen.java 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@              Coverage Diff               @@
##             runtime-mgt   #42414   +/-   ##
==============================================
  Coverage               ?   76.56%           
  Complexity             ?    53543           
==============================================
  Files                  ?     2908           
  Lines                  ?   202351           
  Branches               ?    26342           
==============================================
  Hits                   ?   154936           
  Misses                 ?    38924           
  Partials               ?     8491

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CLAassistant
Copy link

CLAassistant commented Mar 28, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

warunalakshitha
warunalakshitha reviewed Mar 28, 2024
View reviewed changes
...ang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/split/values/JvmObjectGen.java Outdated
@@ -145,6 +154,22 @@ public void createAndSplitCallMethod(ClassWriter cw, List<BIRNode.BIRFunction> f
} else {
jvmCastGen.addBoxInsn(mv, retType);
}
if (func.name.value.equals("attach") &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we check remoteManagement build option?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add that as well after we merge #42336. The option will be available in the CompilerContext.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the latest design changes, the build option will be added through a compiler plugin from the wso2.controlplane module. Those changes will be added in a separate PR.

gabilang
gabilang approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@gabilang gabilang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HindujaB HindujaB closed this Apr 2, 2024
@HindujaB HindujaB reopened this Apr 2, 2024
@HindujaB HindujaB merged commit 6cd56da into ballerina-platform:runtime-mgt Apr 3, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warunalakshitha warunalakshitha warunalakshitha left review comments

@gabilang gabilang gabilang approved these changes

@hasithaa hasithaa hasithaa approved these changes

@sameerajayasoma sameerajayasoma Awaiting requested review from sameerajayasoma

Assignees
No one assigned
Labels
Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HindujaB @CLAassistant @hasithaa @warunalakshitha @gabilang