[2201.8.x] Remove the strandId when doing generateCombinedTransactionId in TransactionResourceManager
#42119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is a separate strand created for a transaction block it registers in the `resourceRegistry` with its strandID. Finally when we commit the original transaction with the main strand and we look in the `resourceRegistry` With the main strandID and the results will be zero. Hence, the transaction won’t be committed. Since `resourceRegistry` is a map that holds list of `BallerinaTransactionContext`s for a given transaction block, we can prevent adding strandID to the keys of `resourceRegistry` which will fix the mismatch because of different strands. (cherry picked from commit 8fa2ffa)
dsplayerX
requested review from
rdulmina,
gimantha,
pcnfernando and
poorna2152
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2201.8.x #42119 +/- ##
===========================================
Coverage 76.30% 76.30%
- Complexity 52566 52567 +1
===========================================
Files 2880 2880
Lines 198959 198946 -13
Branches 25868 25858 -10
===========================================
+ Hits 151806 151810 +4
+ Misses 38795 38784 -11
+ Partials 8358 8352 -6 ☔ View full report in Codecov by Sentry. |
poorna2152
approved these changes
Feb 7, 2024
gimantha
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When there is a separate strand created for a transaction block it registers in the
resourceRegistrywith its strandID. Finally when we commit the original transaction with the main strand and we look in theresourceRegistryWith the main strandID and the results will be zero. Hence, the transaction won’t be committed.Since
resourceRegistryis a map that holds list ofBallerinaTransactionContexts for a given transaction block, we can prevent adding strandID to the keys ofresourceRegistrywhich will fix the mismatch because of different strands.Fixes #41682
Approach
Remove strandId when doing
generateCombinedTransactionIdin TransactionResourceManagerSamples
Test cases added via ballerina-platform/module-ballerina-sql#698
Remarks
[master] PR: #41800
Check List