Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ArrayIndexOutOfBoundsException at parameter count validation of Java interop methods #41943

Merged

Conversation

gabilang
Copy link
Contributor

@gabilang gabilang commented Jan 5, 2024

Purpose

$title

Fixes #41414

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@gabilang gabilang added the Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime label Jan 5, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b2ac9a9) 0.00% compared to head (48941a9) 76.65%.
Report is 10 commits behind head on master.

Files Patch % Lines
.../compiler/bir/codegen/interop/JMethodResolver.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #41943       +/-   ##
=============================================
+ Coverage      0.00%   76.65%   +76.65%     
- Complexity        0    52983    +52983     
=============================================
  Files             9     2883     +2874     
  Lines            35   199857   +199822     
  Branches          0    26009    +26009     
=============================================
+ Hits              0   153210   +153210     
- Misses           35    38180    +38145     
- Partials          0     8467     +8467     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gabilang gabilang marked this pull request as ready for review January 8, 2024 06:04
Copy link
Contributor

@warunalakshitha warunalakshitha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@HindujaB HindujaB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warunalakshitha warunalakshitha merged commit c65f084 into ballerina-platform:master Jan 16, 2024
18 checks passed
@gabilang gabilang deleted the fix-crash-with-interop branch January 22, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Problem on error message when a method is used wrongly without a receiver.
3 participants