Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2201.8.x] Fix time module resolution error in SQL compiler plugin tests #41903

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

ShammiL
Copy link
Contributor

@ShammiL ShammiL commented Dec 18, 2023

Purpose

$Subject

Fixes #41866

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@ShammiL ShammiL changed the title Fix time module resolution error in SQL compiler plugin tests [2201.8.x] Fix time module resolution error in SQL compiler plugin tests Dec 18, 2023
@ShammiL ShammiL force-pushed the sql-time-resolution-8 branch from 6454d97 to dd8ee9a Compare December 18, 2023 18:26
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f957cb1) 76.36% compared to head (58cfc84) 76.36%.
Report is 4 commits behind head on 2201.8.x.

Files Patch % Lines
...ojects/internal/PackageDependencyGraphBuilder.java 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             2201.8.x   #41903   +/-   ##
===========================================
  Coverage       76.36%   76.36%           
- Complexity      52563    52564    +1     
===========================================
  Files            2880     2880           
  Lines          198779   198780    +1     
  Branches        25826    25827    +1     
===========================================
+ Hits           151792   151797    +5     
+ Misses          38631    38626    -5     
- Partials         8356     8357    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azinneera azinneera merged commit 218ea39 into ballerina-platform:2201.8.x Dec 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants