Provide completions after a variable resource path parameter in a resource access action #41628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nipunayf
requested review from
mohanvive,
sameerajayasoma and
hasithaa
as code owners
nipunayf
changed the title
nipunayf
force-pushed
the
fix-variable-resource-path
branch
2 times, most recently
from
b6e1150 to
846a27f
Compare
nipunayf
added
the
Team/LanguageServer
nipunayf
force-pushed
the
fix-variable-resource-path
branch
from
846a27f to
8dec779
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #41628 +/- ##
============================================
- Coverage 76.71% 76.71% -0.01%
+ Complexity 52668 52667 -1
============================================
Files 2880 2880
Lines 198584 198585 +1
Branches 25802 25802
============================================
- Hits 152343 152341 -2
- Misses 37806 37807 +1
- Partials 8435 8437 +2 ☔ View full report in Codecov by Sentry. |
...erina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/TypeChecker.java
Outdated
Show resolved
Hide resolved
KavinduZoysa
previously approved these changes
Nov 13, 2023
nipunayf
force-pushed
the
fix-variable-resource-path
branch
from
dfae157 to
365d8ef
Compare
mindula
reviewed
Nov 13, 2023
.../resources/completion/action_node_context/config/client_resource_access_action_config44.json
Outdated
Show resolved
Hide resolved
nipunayf
force-pushed
the
fix-variable-resource-path
branch
2 times, most recently
from
3d9ce53 to
0f2b1f0
Compare
nipunayf
force-pushed
the
fix-variable-resource-path
branch
from
0f2b1f0 to
a2f69d7
Compare
KavinduZoysa
approved these changes
Nov 21, 2023
KavinduZoysa
merged commit 03b5fb1
into
ballerina-platform:master
16 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$title.
Fixes #41623
Approach
The current implementation of the type checker does not resolve the variable types of the path parameters if it encounters an error. The PR resolves the variable types despite the error conditions.
Samples
Completions are now shown after a resource path parameter with a variable, as shown below.
Check List