Provide completions after variable resource param

ballerina-platform · Nov 6, 2023 · 9ae8b30 · 9ae8b30
1 parent 39298db
commit 9ae8b30
Show file tree

Hide file tree

Showing 3 changed files with 52 additions and 0 deletions.
diff --git a/...na-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/TypeChecker.java b/...na-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/TypeChecker.java
@@ -3823,6 +3823,7 @@ public void visit(BLangInvocation.BLangResourceAccessInvocation resourceAccessIn
         }
 
         if (resourceFunctions.size() == 0) {
+            checkExpr(resourceAccessInvocation.resourceAccessPathSegments, data);
             dlog.error(resourceAccessInvocation.resourceAccessPathSegments.pos, DiagnosticErrorCode.UNDEFINED_RESOURCE,
                     lhsExprType);
             data.resultType = symTable.semanticError;
@@ -3833,10 +3834,12 @@ public void visit(BLangInvocation.BLangResourceAccessInvocation resourceAccessIn
         resourceFunctions.removeIf(func -> !func.accessor.value.equals(resourceAccessInvocation.name.value));
         int targetResourceFuncCount = resourceFunctions.size();
         if (targetResourceFuncCount == 0) {
+            checkExpr(resourceAccessInvocation.resourceAccessPathSegments, data);
             dlog.error(resourceAccessInvocation.name.pos,
                     DiagnosticErrorCode.UNDEFINED_RESOURCE_METHOD, resourceAccessInvocation.name, lhsExprType);
             data.resultType = symTable.semanticError;
         } else if (targetResourceFuncCount > 1) {
+            checkExpr(resourceAccessInvocation.resourceAccessPathSegments, data);
             dlog.error(resourceAccessInvocation.pos, DiagnosticErrorCode.AMBIGUOUS_RESOURCE_ACCESS_NOT_YET_SUPPORTED);
             data.resultType = symTable.semanticError;
         } else {

diff --git a/...sources/completion/action_node_context/config/client_resource_access_action_config44.json b/...sources/completion/action_node_context/config/client_resource_access_action_config44.json
@@ -0,0 +1,40 @@
+{
+  "position": {
+    "line": 7,
+    "character": 25
+  },
+  "source": "action_node_context/source/client_resource_access_action_source37.bal",
+  "description": "",
+  "items": [
+    {
+      "label": "/third",
+      "kind": "Function",
+      "detail": "()",
+      "documentation": {
+        "right": {
+          "kind": "markdown",
+          "value": "**Package:** _._  \n  \n  \n**Params**  \n- `string` second"
+        }
+      },
+      "sortText": "C",
+      "filterText": "third|get",
+      "insertText": "/third;",
+      "insertTextFormat": "Snippet",
+      "additionalTextEdits": [
+        {
+          "range": {
+            "start": {
+              "line": 7,
+              "character": 24
+            },
+            "end": {
+              "line": 7,
+              "character": 25
+            }
+          },
+          "newText": ""
+        }
+      ]
+    }
+  ]
+}
diff --git a/...esources/completion/action_node_context/source/client_resource_access_action_source37.bal b/...esources/completion/action_node_context/source/client_resource_access_action_source37.bal
@@ -0,0 +1,9 @@
+client class MyClient {
+    resource function get first/[string second]/third() {}
+}
+
+public function main() {
+    string someVar = "check";
+    MyClient cl = new;
+    cl->/first/[someVar]/;
+}