Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: cloud: env vars: restart supervisor to speed up tests #3610

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

rcooke-warwick
Copy link
Contributor

@rcooke-warwick rcooke-warwick commented Feb 6, 2025

Tests can get stuck here for 15 to 20 minutes if the timings are unlucky. Forcing a supervisor restart ensures a clean slate and ensures that the variables are included as quickly as possible

Saves 15+ minutes in some cases

fix for recurring test issue discovered as part of https://balena.fibery.io/Inputs/Research/OS-testing-failures-and-issues-1147

Change-type: patch


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

Tests can get stuck here for 15 to 20 minutes if the timings are unlucky. Forcing a supervisor restart ensures a clean slate and ensures that the variables are included as quickly as possible

Change-type: patch
Signed-off-by: Ryan Cooke <[email protected]>
Copy link
Contributor

flowzone-app bot commented Feb 6, 2025

Website deployed to CF Pages, 👀 preview link https://d063844e.balena-os.pages.dev

@klutchell klutchell requested a review from pipex February 6, 2025 13:57
@klutchell
Copy link
Collaborator

@pipex @rcooke-warwick is the bad timing just related to the poll interval or is something else going on?

@rcooke-warwick
Copy link
Contributor Author

rcooke-warwick commented Feb 6, 2025

EDIT: Ignore me

@pipex
Copy link
Contributor

pipex commented Feb 6, 2025

I don't have a ton of context, but from a quick glance at the linked research, the polling hypothesis makes sense to me. In the worst case, if the change takes place close to the end beginning of a polling interval, the supervisor would have to wait a full interval to get the updated data, meaning the test would also be waiting during that time.

@rcooke-warwick rcooke-warwick marked this pull request as ready for review February 6, 2025 17:00
@rcooke-warwick rcooke-warwick merged commit b51dd56 into master Feb 6, 2025
161 of 163 checks passed
@rcooke-warwick rcooke-warwick deleted the ryan/cloud-speed branch February 6, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants