-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: cloud: env vars: restart supervisor to speed up tests #3610
Conversation
Tests can get stuck here for 15 to 20 minutes if the timings are unlucky. Forcing a supervisor restart ensures a clean slate and ensures that the variables are included as quickly as possible Change-type: patch Signed-off-by: Ryan Cooke <[email protected]>
Website deployed to CF Pages, 👀 preview link https://d063844e.balena-os.pages.dev |
@pipex @rcooke-warwick is the bad timing just related to the poll interval or is something else going on? |
EDIT: Ignore me |
I don't have a ton of context, but from a quick glance at the linked research, the polling hypothesis makes sense to me. In the worst case, if the change takes place close to the |
Tests can get stuck here for 15 to 20 minutes if the timings are unlucky. Forcing a supervisor restart ensures a clean slate and ensures that the variables are included as quickly as possible
Saves 15+ minutes in some cases
fix for recurring test issue discovered as part of https://balena.fibery.io/Inputs/Research/OS-testing-failures-and-issues-1147
Change-type: patch
Contributor checklist
Change-type
present on at least one commitSigned-off-by
is presentReviewer Guidelines