Add DownloadImageModal component #17
Conversation
JSReds
force-pushed
the
add-download-image-modal
branch
5 times, most recently
from
29caf00 to
81f19c0
Compare
drskullster
force-pushed
the
add-download-image-modal
branch
from
c27f7e7 to
f584d08
Compare
JSReds
force-pushed
the
add-download-image-modal
branch
from
f584d08 to
e6ece62
Compare
|
sorry for removing the contribution @drskullster 🙏 🙏 🙏 🙏 |
drskullster
force-pushed
the
add-download-image-modal
branch
from
e6ece62 to
7f47343
Compare
JSReds
force-pushed
the
add-download-image-modal
branch
2 times, most recently
from
52296c7 to
29ed598
Compare
JSReds
force-pushed
the
add-download-image-modal
branch
3 times, most recently
from
8df11ce to
d272696
Compare
JSReds
force-pushed
the
add-download-image-modal
branch
from
d272696 to
b41b00c
Compare
| @@ -32,7 +32,9 @@ const preview: Preview = { | |||
| decorators: [ | |||
| (Story) => ( | |||
| <ThemeProvider theme={theme}> | |||
| <Story /> | |||
| <ScopedCssBaseline> | |||
There was a problem hiding this comment.
Just to make sure, I believe @drskullster mentioned he was going to add this in a standalone PR. Was using this agreed upon?
| ); | ||
|
|
||
| export const transformVersions = (versions: OsVersion[]) => { | ||
| // Get a single object per stripped version, with both variants of it included (if they exist). It expects a sorted ` |
There was a problem hiding this comment.
It expects a sorted `
Perhaps I am just not understanding, is this a complete thought? 😓
There was a problem hiding this comment.
nice catch, that was an old comment, not sure where it come from, btw it was probably a sorted OsVersion array. I'll remove it as it is not really necessary.
| @@ -0,0 +1,139 @@ | |||
| export interface Dictionary<T> { | |||
There was a problem hiding this comment.
Just curious, I don't want to complicate this PR further so we can leave it as is regardless of your answer:
Did we just bring these typings over from rendition or did you go through them all and filter out anything we no longer need?
There was a problem hiding this comment.
I should have removed all unnecessary types. Next step would be to unify what is used in multiple places
| > | ||
| <Box display="flex" flexDirection="column"> | ||
| <FormControlLabel | ||
| sx={{ opacity: isDisabled ? 0.6 : 1 }} |
There was a problem hiding this comment.
Is 0.6 the opacity we use everywhere else? Asking because I've seen us using 0.4 in other places (but it could easily have been for a different case)
There was a problem hiding this comment.
we should make a generic "disabled" rule in the theme adding it in design-tokens first. For now I've switched to 0.4 which is probably better.
JSReds
force-pushed
the
add-download-image-modal
branch
2 times, most recently
from
a643b34 to
bccb3cd
Compare
Change-type: minor
JSReds
force-pushed
the
add-download-image-modal
branch
from
8e506f9 to
3bc7c0c
Compare
Change-type: minor