Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depth overlay updates : only use the stencil mask approach when the shader exports depth #3212

Merged
merged 5 commits into from
Jan 11, 2024
Merged

Depth overlay updates : only use the stencil mask approach when the shader exports depth #3212

merged 5 commits into from
Jan 11, 2024

Conversation

Zorro666
Copy link
Collaborator

Description

  • use the non-stencil mask approach by default
  • use the stencil mask approach when the shader exports depth
  • the stencil mask approach shows discarded fragments as failing the depth test and the non-stencil mask approach ignores discarded fragments
  • added depth overlay test for a shader using discard but not exporting depth (test fails before the code change and passes after the code change)

@Zorro666
Depth overlay tests include a shader with discard
d660390
@Zorro666
D3D11 Depth Overlay use non-stencil mask approach by default
23c59a8 
Only use stencil mask approach for depth exporting shaders.
The stencil mask approach does not show discarded pixels as passing.
@Zorro666
D3D12 Depth Overlay use non-stencil mask approach by default
244fdfe 
Only use stencil mask approach for depth exporting shaders.
The stencil mask approach does not show discarded pixels as passing.
@Zorro666
VK Depth Overlay use non-stencil mask approach by default
c2465f7 
Only use stencil mask approach for depth exporting shaders.
The stencil mask approach does not show discarded pixels as passing.
@Zorro666
GL Depth Overlay use non-stencil mask approach by default
3cb776d 
Only use stencil mask approach for depth exporting shaders.
The stencil mask approach does not show discarded pixels as passing.
@Zorro666 Zorro666 force-pushed the depth-overlay-fixes branch from 33c2bcc to 3cb776d Compare January 11, 2024 10:37
@Zorro666 Zorro666 merged commit d0166c0 into baldurk:v1.x Jan 11, 2024
16 checks passed
@Zorro666 Zorro666 deleted the depth-overlay-fixes branch January 11, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Zorro666