Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add D3D12 pixel history implementation #3164

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

skarolewics
Copy link
Contributor

It is disabled by default but can be enabled in the config editor via D3D12/PixelHistory.

This is the last commit needed for testing and continued validation/improvement of D3D12 pixel history. There will be one follow-up commit to add an automated smoke test (similar to the Vulkan pixel history test).

It is disabled by default but can be enabled in the config editor
via D3D12/PixelHistory.
@Zorro666 Zorro666 self-requested a review December 11, 2023 09:23
Copy link
Collaborator

@Zorro666 Zorro666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all your work on this - it is a great starting place.

One minor change to make the config option be developer only until the feature is more tested and robust.

I gave it a quick trial on a simple D3D12 draw triangle capture I have and it worked to get the per fragment colour but didn't appear to be correct at a per event i.e. the clear result was the wrong colour and the one fragment that touched the pixel didn't get updated correctly but the per fragment value was correct.

I have seen this before in the other API pixel history : it usually a quick fix which will can be the starting point after this PR and the follow up test PR is merged.

image

renderdoc/driver/d3d12/d3d12_replay.cpp Show resolved Hide resolved
@Zorro666 Zorro666 merged commit ad2070c into baldurk:v1.x Dec 12, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants