Add discarded fragment callback for D3D12 pixel history #3136
Conversation
skarolewics
force-pushed
the
pixelhistory2
branch
from
443ba88 to
e573b33
Compare
There was a problem hiding this comment.
Apologies for the long delay for reviewing (have been away travelling).
Thank you again for the D3D12 pixel history work.
Made some small comments/thoughts which do not need to be actioned.
Looking forward to the end result of your D3D12 pixel history work being in RenderDoc so it can be continued forward and then included in the product
| struct D3D12PixelHistoryDiscardedFragmentsCallback : D3D12PixelHistoryCallback | ||
| { | ||
| // Key is event ID and value is a list of primitive IDs | ||
| std::map<uint32_t, rdcarray<int32_t>> m_Events; |
There was a problem hiding this comment.
Pure thought/comment and no need to change anything
In principal this could be const but would need to change the access to it i.e. use at or use the result of the find
| if(m_Events.find(eid) == m_Events.end()) | ||
| return; | ||
|
|
||
| const rdcarray<int32_t> &primIds = m_Events[eid]; |
There was a problem hiding this comment.
Pure comment and no need to change anything.
Nice optimisation to use a reference and not copy the array (like Vulkan does).
This could be optimized slightly further by using the result from the find
No description provided.