Couple of small fixes: add a link to the buffer view documents, change the buffer viewer error style for dark mode #3131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baldurk
requested changes
Nov 13, 2023
| QColor col = QColor::fromHslF(0.0f, 1.0f, qBound(0.1, base.lightnessF(), 0.9)); | ||
| QColor col = IsDarkTheme() | ||
| ? QColor::fromHslF(0.0f, 1.0f, qBound(0.1, 1.0f - base.lightnessF(), 0.9)) | ||
| : QColor::fromHslF(0.0f, 1.0f, qBound(0.1, base.lightnessF(), 0.9)); |
There was a problem hiding this comment.
Dark themes are all about light-text-on-dark-background. The bug here is that we customise the background colour without also customising the foreground colour. A better fix here would be to keep the base colour as-is but then use the contrastingColor helper to pick the appropriate text colour to best contrast with it (which on a dark theme will produce light text).
See e.g. D3D11PipelineStateViewer::highlightIABind for how it's used.
Zorro666
force-pushed
the
small-fixes
branch
from
ea46a87 to
965cb73
Compare
This makes it automatically work for Light or Dark theme
Zorro666
force-pushed
the
small-fixes
branch
from
965cb73 to
d0165a1
Compare
baldurk
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a link to "below section" to the buffer viewer struct docs
In dark mode invert the lightness for the buffer format error style
Before Buffer Format Error
Dark Mode
After Buffer Format Error
Dark Mode
Light Mode