Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Android SDK/JDK setting tooltips to match RDOC_CONFIG #3120

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

w-pearson
Copy link
Contributor

Previously, the SDK tooltip was inconsistent between the label and the text field/button, with the latter incorrectly saying the location of adb.exe should be used. There also was no description at all for the JDK option.

image
image

I've copied the descriptions from the RDOC_CONFIG macros in android_tools.cpp, which should make it easier to set these correctly.

RDOC_CONFIG(rdcstr, Android_SDKDirPath, "",
"The location of the root of the Android SDK. This path "
"should contain folders such as build-tools and platform-tools.");
RDOC_CONFIG(rdcstr, Android_JDKDirPath, "",
"The location of the root of the Java JDK. This path "
"should contain folders such as bin and lib.");

Previously, the SDK tooltip was inconsistent between the label and the
text field/button, with the latter incorrectly saying the location of
adb.exe should be used. There also was no description at all for the
JDK option.

I've copied the descriptions from the RDOC_CONFIG macros in
android_tools.cpp, which should make it easier to set these correctly.
@baldurk baldurk merged commit b531fe9 into baldurk:v1.x Nov 9, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants