Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android extra flags not applied on initial CMake generation #3117

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Android extra flags not applied on initial CMake generation #3117

merged 1 commit into from
Nov 7, 2023

Conversation

cmannett85-arm
Copy link
Collaborator

@cmannett85-arm cmannett85-arm commented Nov 7, 2023 •
edited
Loading

CMAKE_CXX_FLAGS was overwritten if not already in the cache (i.e. when first built). Presumably down to toolchain loading order.

baldurk
baldurk requested changes Nov 7, 2023
View reviewed changes
Copy link
Owner

@baldurk baldurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please keep the definition of ANDROID? It's possible some past or future NDK won't define that, and a redundant definition does no harm for those that do.

@cmannett85-arm
Android extra flags not applied on initial CMake generation
eccc3cd 
CMAKE_CXX_FLAGS was overwritten if not already in the cache (i.e. when first built).  Presumably down to toolchain loading order.
@baldurk baldurk merged commit ec408e2 into baldurk:v1.x Nov 7, 2023
16 checks passed
@cmannett85-arm cmannett85-arm deleted the cm_fix branch November 7, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baldurk baldurk Awaiting requested review from baldurk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmannett85-arm @baldurk