When loading a layout close any orphaned windows #3115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue
Pipeline State
Pipeline State
windowPipeline State
window because it has become orphaned (no parent) from any tool window manager. Have to restart RenderDoc to be able to open the orphaned windows.Discussion
raiseToolWindow
similar to how it is done foraddToolWindow
and use the default tool area if the window has become orphaned.raiseToolWindow
(approximately 45 instances)m_ToolWindows
so anything iterating over that container and sending events could be sending events to ToolWindows which are not visible.closeToolWindow
API which might lead to invalid ToolWindow's i.e. ToolWindow's referencing a capture that has been closed but the ToolWindow itself became orphanedExtra Changes
Testing
Following steps mentioned end up with logs like this and are able to open windows which without the fix had not been able to open.