Reset the PixelUnpackState for replay serialisation of glTexImage* APIs
#3113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Covers: glTexImage1D glTexImage2D glTexImage3D
The pixel data has been serialized as pure bytes with no padding or packing. It was already handled in: glTexSubImage1D glTexSubImage2D glTexSubImage3D glCompressedTexSubImage1D glCompressedTexSubImage2D glCompressedTexSubImage1D Apply the same handling to: glTexImage1D glTexImage2D glTexImage3D glCompressedTexImage1D glCompressedTexImage2D glCompressedTexImage3D These APIs do not handle a non-zero offset with the GL_PIXEL_UNPACK_BUFFER
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reset the
PixelUnpackStatefor replay serialisation of the following APIs:glTexImage1DglTexImage2DglTexImage3DglCompressedTexImage1DglCompressedTexImage2DglCompressedTexImage3DDid NOT add support for non-zero
pixelsparameter being used as an offset toGL_PIXEL_UNPACK_BUFFERNotes
Could extend this work by:
pixelsparameter used as an offset toGL_PIXEL_UNPACK_BUFFER(it looks like it would need capture changes to serialize extra data)UNPACK_ROW_LENGTHand to cover theglCompressedTexImage?DAPIsTesting
Added a basic test for to
gl_texture_zoofor non-zeroUNPACK_ROW_LENGTHfor the following APIs:glTexImage1DglTexImage2DglTexImage3DThe test fails before the code change and passes afterwards.
Background
Looking at GL APIs related to storing pixel data into textures discovered the following:
GL APIs affected by
glPixelStoreglTexImage1DglTexImage2DglTexImage3DglCompressedTexImage1DglCompressedTexImage2DglCompressedTexImage3DglTexSubImage1DglTexSubImage2DglTexSubImage3DglCompressedTexSubImage1DglCompressedTexSubImage2DglCompressedTexSubImage1DAPIs that handle
glPixelStoreparameters during RenderDoc replayglTexSubImage1DglTexSubImage2DglTexSubImage3DglCompressedTexSubImage1DglCompressedTexSubImage2DglCompressedTexSubImage1DThese APIs also DO support pixels being an offset into
GL_PIXEL_UNPACK_BUFFERAPIs that do not handle
glPixelStoreparameters during RenderDoc replayglTexImage1DglTexImage2DglTexImage3DglCompressedTexImage1DglCompressedTexImage2DglCompressedTexImage3DThese APIs also DO NOT support the
pixelsparameter being a non-zero offset intoGL_PIXEL_UNPACK_BUFFER(which is supported by the replay serialisation of the other GL texture storage APIs).