Add FreeBSD operating system support. #3108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baldurk
requested changes
Nov 3, 2023
There was a problem hiding this comment.
This looks OK to me in terms of changes that are safe for supported platforms so they are mostly a no-op. I've made some comments on things that should change or be reverted.
Also just to set expectations - this will remain an unsupported platform even after this PR, so bugs on it won't be fixed (unless someone PR's a fix) and it won't be tested in CI or on release in any way, so it may stop compiling or break with future changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds support of FreeBSD operating system.
Also modification in thirdparty catch library was made to support debugger check.
FreeBSD at the moment have broken
environglobal variable so some linux hooks were disabled.freebsd_process.cppis based onapple_process.cpp