Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor MEV capture hook refactor #1277

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Minor MEV capture hook refactor #1277

merged 2 commits into from
Feb 11, 2025

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented Feb 11, 2025

Description

Minor refactor:

  • isMevTaxExempt --> isMevTaxExemptSender for consistency
  • Some < --> <= changes. Doesn't really affect the code because in the edges the fee increment is 0, so it's just returning earlier with the same result.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Optimization: [ ] gas / [ ] bytecode
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

Issue Resolution

N/A

Copy link
Contributor

@elshan-eth elshan-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One test is down but other things LGTM

Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Did they ask for the <= changes? The failing test seems unrelated. Did something change in the environment to make us start having these intermittent failures now? Add this to the list?

@jubeira jubeira merged commit e453174 into main Feb 11, 2025
13 of 14 checks passed
@jubeira jubeira deleted the minor-mev-tax-hook-fixes branch February 11, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants