-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created helm chart for BaGetter #117
Conversation
/health endpoint is not released in the latest container image
The health probes are prepared but commented out. The default endpoint is not /healthz
chart/bagetter/Chart.yaml
Outdated
# incremented each time you make changes to the application. Versions are not expected to | ||
# follow Semantic Versioning. They should reflect the version the application is using. | ||
# It is recommended to use it with quotes. | ||
appVersion: "1.0.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about increasing this version number? We use the Git tags and GitHub actions to set the version of BaGetter. I think you have to edit the .github/workflows/release.yml
and add a new job where the source code of the file (version number) gets replaced by the action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I was thinking about that, too.
I need to look into it...
chart/bagetter/README.md
Outdated
@@ -0,0 +1,36 @@ | |||
# bagetter | |||
|
|||
![Version: 0.1.0](https://img.shields.io/badge/Version-0.1.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.0.4](https://img.shields.io/badge/AppVersion-1.0.4-informational?style=flat-square) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AppVersion is here static, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was generated by helm-docs
Should be re-generated by release.yml
, too
How about a |
Yeah then you could add Docker-Swarm too. |
I can move the directory to |
@Khaos66 Please do, then I'll merge this. |
@Regenhardt Thank you for the reminder! |
ci: Create helm chart for BaGetter (bagetter#117)
Hi, where is the helm chart hosted? there are no instructions to install it |
I was under the impression you don't have to "install" the helm chart but download the files, fill the variables with your values, and then execute it via helm. @Khaos66 you know more about this stuff, is there another step we should take here? |
Yes, right. There is the concept of a help chart repo, where you can publish your charts to and users can install them from there. But this project doesn't have a repo. @HaimKortovich The way I use the chart is:
See helm install for more info |
A chart repo can be a github pages if its possible I can create the CI |
Just discovered this cool project. I would really appreciate a helm repo being setup to make my deployment easier as I'm using GitOps (specifically flux) for my k8s cluster. |
Same here I'll try making a PR in the following hours |
Adds a helm chart to deploy all resources for BaGetter to k8s
Adresses #116