Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created helm chart for BaGetter #117

Merged
merged 9 commits into from
Jul 13, 2024
Merged

Conversation

Khaos66
Copy link

@Khaos66 Khaos66 commented Mar 14, 2024

Adds a helm chart to deploy all resources for BaGetter to k8s

Adresses #116

Khaos66 added 5 commits March 14, 2024 22:01
/health endpoint is not released in the latest container image
The health probes are prepared but commented out. The default endpoint is not /healthz
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: "1.0.4"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about increasing this version number? We use the Git tags and GitHub actions to set the version of BaGetter. I think you have to edit the .github/workflows/release.yml and add a new job where the source code of the file (version number) gets replaced by the action.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I was thinking about that, too.
I need to look into it...

@@ -0,0 +1,36 @@
# bagetter

![Version: 0.1.0](https://img.shields.io/badge/Version-0.1.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.0.4](https://img.shields.io/badge/AppVersion-1.0.4-informational?style=flat-square)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppVersion is here static, too.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was generated by helm-docs
Should be re-generated by release.yml, too

@Regenhardt
Copy link

How about a deployment templates directory with its own readme, then in there a Helm directory for the chart, and a Ansible-Helm directory for the ansible playbook deploying the helm chart? That way others like docker-compose already have a set structure to be added to in the future and we have a readme there that can explain how to use the templates.

@seriouz
Copy link

seriouz commented Mar 18, 2024

Yeah then you could add Docker-Swarm too.

@Khaos66
Copy link
Author

Khaos66 commented Mar 20, 2024

I can move the directory to deployment templates sure.

@Regenhardt Regenhardt linked an issue Jun 25, 2024 that may be closed by this pull request
@Regenhardt
Copy link

@Khaos66 Please do, then I'll merge this.

@Khaos66
Copy link
Author

Khaos66 commented Jul 8, 2024

@Regenhardt Thank you for the reminder!
I did move the chart.
I also extended release.yml with a job to update the chart.

@Regenhardt Regenhardt merged commit 0f16eaa into bagetter:main Jul 13, 2024
2 checks passed
lkonrad-q-soft added a commit to lkonrad-q-soft/BaGetter that referenced this pull request Jul 19, 2024
ci: Create helm chart for BaGetter (bagetter#117)
@HaimKortovich
Copy link

Hi, where is the helm chart hosted? there are no instructions to install it

@Regenhardt
Copy link

Hi, where is the helm chart hosted? there are no instructions to install it

I was under the impression you don't have to "install" the helm chart but download the files, fill the variables with your values, and then execute it via helm. @Khaos66 you know more about this stuff, is there another step we should take here?

@Khaos66
Copy link
Author

Khaos66 commented Sep 7, 2024

Yes, right. There is the concept of a help chart repo, where you can publish your charts to and users can install them from there. But this project doesn't have a repo.

@HaimKortovich The way I use the chart is:

  • git clone the repo
  • build the helm chart
  • install the helm chart
helm dependency build ./bagetter/deployment templates/chart/bagetter

helm install -f myvalues.yml bagetter ./bagetter/deployment templates/chart/bagetter

See helm install for more info

@HaimKortovich
Copy link

A chart repo can be a github pages if its possible I can create the CI

@Amith211
Copy link

Amith211 commented Sep 8, 2024

Just discovered this cool project. I would really appreciate a helm repo being setup to make my deployment easier as I'm using GitOps (specifically flux) for my k8s cluster.

@HaimKortovich
Copy link

Same here I'll try making a PR in the following hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supply a helm chart
5 participants