Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the most strict interpretation for Basic Auth encoding #172

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

p2004a
Copy link
Contributor

@p2004a p2004a commented Feb 9, 2025

Amends 49d3241 per discussion in #171 with the most strict interpretation of required encoding for the HTTP Basic Authentication user and password.

Amends 49d3241 per discussion in
badgateway#171 with the most
strict interpretation of required encoding for the HTTP Basic
Authentication user and password.
@panva
Copy link

panva commented Feb 9, 2025

It should be noted that this, as well as 49d3241 is a breaking change given the server interop mess.

@evert
Copy link
Collaborator

evert commented Feb 9, 2025

Depressing that it's needed, but needed nonetheless! Thank you! Great contribution

@evert evert merged commit 004f47b into badgateway:main Feb 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants