Making every Finder strategy able to understand buildCacheFromTestSuite:

For a static selection strategy, this method does nothing because there is no cache.
badetitou · Jul 5, 2019 · b2f4de1 · b2f4de1
1 parent 9d8b882
commit b2f4de1
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/src/SmartTest/SmTSenderTestFinderStrategy.class.st b/src/SmartTest/SmTSenderTestFinderStrategy.class.st
@@ -14,6 +14,11 @@ SmTSenderTestFinderStrategy class >> isConcreteFinder [
 	^ true
 ]
 
+{ #category : #api }
+SmTSenderTestFinderStrategy >> buildCacheFromTestSuite: aTestSuite [
+	"No cache for static finder"
+]
+
 { #category : #'private - search' }
 SmTSenderTestFinderStrategy >> collectSenderOfRGMethodeDefintion: aRGMethodDefinition [
 	^ aRGMethodDefinition isInitializer

diff --git a/src/SmartTest/SmTTestFinderStrategy.class.st b/src/SmartTest/SmTTestFinderStrategy.class.st
@@ -18,6 +18,11 @@ SmTTestFinderStrategy class >> isConcreteFinder [
 	^ false
 ]
 
+{ #category : #api }
+SmTTestFinderStrategy >> buildCacheFromTestSuite: aTestSuite [
+	self subclassResponsibility
+]
+
 { #category : #accessing }
 SmTTestFinderStrategy >> cache [
 	^ cache

diff --git a/src/SmartTest/SmartFinder.class.st b/src/SmartTest/SmartFinder.class.st
@@ -230,8 +230,9 @@ SmartFinder >> autoUpdateCache: aBoolean [
 
 { #category : #api }
 SmartFinder >> buildCacheFromTestSuite: aTestSuite [
-	"Work only if you have selected a Dynamic strategy"
-	self smtFinder buildCacheFromTestSuite: aTestSuite 
+	"Cache will be built only for a dynamic strategy"
+
+	self smtFinder buildCacheFromTestSuite: aTestSuite
 ]
 
 { #category : #accessing }