Skip to content

resolved comments from PR and changed return type of MultiSketch::load #9

resolved comments from PR and changed return type of MultiSketch::load

resolved comments from PR and changed return type of MultiSketch::load #9

GitHub Actions / clippy succeeded Aug 7, 2024 in 0s

clippy

5 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 5
Note 0
Help 0

Versions

  • rustc 1.82.0-nightly (60d146580 2024-08-06)
  • cargo 1.82.0-nightly (fa6465836 2024-08-02)
  • clippy 0.1.82 (60d1465 2024-08-06)

Annotations

Check warning on line 218 in src/distances.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

non-canonical implementation of `partial_cmp` on an `Ord` type

warning: non-canonical implementation of `partial_cmp` on an `Ord` type
   --> src/distances.rs:214:1
    |
214 | /  impl PartialOrd for SparseCoreAcc {
215 | |      fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
    | | _____________________________________________________________-
216 | ||         self.1.partial_cmp(&other.1)
217 | ||     }
    | ||_____- help: change this to: `{ Some(self.cmp(other)) }`
218 | |  }
    | |__^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl

Check warning on line 192 in src/distances.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

non-canonical implementation of `partial_cmp` on an `Ord` type

warning: non-canonical implementation of `partial_cmp` on an `Ord` type
   --> src/distances.rs:188:1
    |
188 | /  impl PartialOrd for SparseJaccard {
189 | |      fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
    | | _____________________________________________________________-
190 | ||         other.1.partial_cmp(&self.1) // NB: backwards
191 | ||     }
    | ||_____- help: change this to: `{ Some(self.cmp(other)) }`
192 | |  }
    | |__^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl
    = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default

Check warning on line 215 in src/sketch.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (9/7)

warning: this function has too many arguments (9/7)
   --> src/sketch.rs:205:1
    |
205 | / pub fn sketch_files(
206 | |     output_prefix: &str,
207 | |     input_files: &[InputFastx],
208 | |     concat_fasta: bool,
...   |
214 | |     min_qual: u8,
215 | | ) -> Vec<Sketch> {
    | |________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
    = note: `#[warn(clippy::too_many_arguments)]` on by default

Check warning on line 11 in src/sketch_datafile.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

fields `bin_stride`, `kmer_stride`, and `sample_stride` are never read

warning: fields `bin_stride`, `kmer_stride`, and `sample_stride` are never read
  --> src/sketch_datafile.rs:11:5
   |
10 | pub struct SketchArrayFile {
   |            --------------- fields in this struct
11 |     bin_stride: usize,
   |     ^^^^^^^^^^
12 |     kmer_stride: usize,
   |     ^^^^^^^^^^^
13 |     sample_stride: usize,
   |     ^^^^^^^^^^^^^
   |
   = note: `SketchArrayFile` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
   = note: `#[warn(dead_code)]` on by default

Check warning on line 150 in src/multisketch.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `ids`

warning: unused variable: `ids`
   --> src/multisketch.rs:150:35
    |
150 |     pub fn remove_sketches(&self, ids: &[String]) {
    |                                   ^^^ help: if this is intentional, prefix it with an underscore: `_ids`
    |
    = note: `#[warn(unused_variables)]` on by default