Bacpop-209 Beebop:AMR info to Microreact #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absternator
changed the title
absternator
changed the title
…nto bacpop-209-amr-microreact
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## bacpop-186-v9-db #87 +/- ##
=================================================
Coverage 98.83% 98.84%
=================================================
Files 34 34
Lines 2064 2075 +11
Branches 271 271
=================================================
+ Hits 2040 2051 +11
Misses 24 24 ☔ View full report in Codecov by Sentry. |
EmmaLRussell
approved these changes
Jan 20, 2025
| } | ||
|
|
||
| export interface AMRMetadataCsv extends AMRForCsv { | ||
| ID: string; |
There was a problem hiding this comment.
..deviating from more customary lower case id..?
There was a problem hiding this comment.
yeah just the format the microeact defaults to (ID)
good idea will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in conjunction with beebop_py pr.
The purpose is to pass along AMR information to an info_csv metadata file that is passed into visualise for microreact. This means that this AMR info will show on the table when visiting microreact page.
Also added Status column as default into microreact and sorted so query samples show first before ref samples.
Testing:
Create a project with samples and run. Then visit microreact, the AMR columns should show by default and query samples should be on top of ref samples.
have also deployed on beebop-dev if its easier