Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Return full consumer info and remove DB object usage in x/btcstkconsumer queries #470

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

SebastianElvis
Copy link
Member

Resolves #261

This PR

  • changes the x/btcstkconsumer APIs to return full consumer register metadata
  • removes all usage of DB objects in queries

@SebastianElvis SebastianElvis changed the title api: return full consumer info and separate query objects api: Return full consumer info and remove DB object usage in x/btcstkconsumer queries Feb 4, 2025
Copy link
Contributor

@gusin13 gusin13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! some initial comments

proto/babylon/btcstkconsumer/v1/query.proto Outdated Show resolved Hide resolved
proto/babylon/btcstkconsumer/v1/query.proto Show resolved Hide resolved
@SebastianElvis SebastianElvis merged commit b11db7c into main Feb 7, 2025
24 checks passed
@SebastianElvis SebastianElvis deleted the fix-consumer-registry-api branch February 7, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

return full consumer metadata in ConsumerRegistryList endpoint
2 participants