chore: epoch handle staking msg server #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add chain register struct * Add chain registry * Add chain registry test * Add chain registry queries * Add chain registry queries tests * Add register chain msg * Add register chain msg routing / impl * Update proto/babylon/zoneconcierge/v1/tx.proto * Flatten chain register proto * Remove authority from register chain msg * Add chain not registered check * Add chain already registered check * Update / fix comment * Add registry related queries to rpc server * Fix indentation * Fix: Add signer field to register chain msg * Fix: Own / unique query param / response for list registry
* Move btcstkconsumer proto files under v1/ for consistency * Move register chain protos from zoneconcierge to btcstkconsumer * Refactor chain registry into btcstkconsumer * Fix: proto / code lints * Pass chain register pointer Co-authored-by: Runchao Han <[email protected]>
* Register zoneconcierge msg codecs * Register btcstkconsumer msg codecs
* Add chain id to finality provider * Add finality provider registry * Update fps per chain id registry * Remove commented line * FP registers only non-canonical chains * Add FP registry test * Add registered chain check * Add registration check to fp registry test * Remove optional from chain id * Add own CZ chains FPs store * Store CZ chains FPs in their own store * Adjust names / tests * Refactor fp consumer registry * Adapt tests * Rename for clarity * Add FP CZ chains registry queries * Add FP consumer query tests * Adapt test * Add chain id to fp query response * Remove useless slash condition check * Improve error msg * Move type builder to types package
* Add chains per FP BTC PubKey store * Ensure CZ chains FP does not already exist * Fix: Return err explicitly instead of nil
* Fix typos * Add register chain cli tx * Add chain id to btcstaking create-finality-provider * Add get finality provider by chain queries * Add registered chains cli queries * Add FZ FP chain id query type * Add get CZ FP chain getter / query * Add grpc query. Adjust grpc query paths * Add CZ FP registered chain cli query cmd * Fix: Add tx flags for register chain cmd * Turn consumer chain id into a flag instead of a param * Fix params module import * Add hook to query consumer fps through btcstaking
* Rename consumer keys for clarity * Rename btc staking consumer methods * Rename consumer delegation private methods * Move consumer delegations to btcstaking * Refactor BTC delegations into one store * Simplify logic * Improve comments
* Add needed (for babylon as Consumer) staking capability * Upgrade contracts from latest babylon-contract * Support Mac arm64 arch in passing for copy local wasm * Fix: FP fields protobuf sequence numbers * Update contracts to latest * Fix: make proto-gen * Trim unused fields from new finality provider IBC msg * Update protobuf gens * Update code refs
RafilxTenfen
requested review from
KonradStaniec,
SebastianElvis,
maurolacy and
Lazar955
RafilxTenfen
commented
Jan 28, 2025
| @@ -412,7 +412,7 @@ func (ak *AppKeepers) InitKeepers( | |||
| appparams.AccGov.String(), | |||
| ) | |||
|
|
|||
| wasmOpts = append(owasm.RegisterCustomPlugins(&ak.EpochingKeeper, &ak.CheckpointingKeeper, &ak.BTCLightClientKeeper, &ak.ZoneConciergeKeeper), wasmOpts...) | |||
| wasmOpts = append(owasm.RegisterCustomPlugins(&epochingKeeper, &ak.CheckpointingKeeper, &ak.BTCLightClientKeeper, &ak.ZoneConciergeKeeper), wasmOpts...) | |||
There was a problem hiding this comment.
ak.EpochingKeeper was not set yet
RafilxTenfen
commented
Jan 28, 2025
| @@ -97,7 +97,7 @@ func FuzzHandleQueuedMsg_MsgWrappedDelegate(f *testing.F) { | |||
| require.Equal(t, uint64(0), lc.ValLife[0].BlockHeight) | |||
|
|
|||
| // delegate a random amount of tokens to the validator | |||
| numNewDels := r.Int63n(1000) + 1 | |||
| numNewDels := r.Int63n(15) + 1 | |||
There was a problem hiding this comment.
if left as 1k new dels it breaks the cosmos-sdk/types.TypedEventToEvent to parse the event, was not able to find the root of the issue
goroutine 41 [chan receive, 1 minutes]:
testing.(*F).Fuzz.func1({0x507ab20, 0xc0018a5c00}, {{0x0, 0x0}, {0xc0006d9420, 0x6}, {0x0, 0x0, 0x0}, {0xc000f98c20, ...}, ...})
/home/rafilx/go/pkg/mod/golang.org/[email protected]/src/testing/fuzz.go:337 +0x58a
testing.(*F).Fuzz(0xc0018a5c00, {0x316d8a0, 0x4bfe638})
/home/rafilx/go/pkg/mod/golang.org/[email protected]/src/testing/fuzz.go:402 +0xab7
github.com/babylonlabs-io/babylon/x/epoching/keeper_test.FuzzHandleQueuedMsg_MsgWrappedDelegate(0xc0018a5c00)
/home/rafilx/projects/github.com/babylonlabs-io/babylon/x/epoching/keeper/epoch_msg_queue_test.go:67 +0x35
testing.fRunner(0xc0018a5c00, 0x4bfe490)
/home/rafilx/go/pkg/mod/golang.org/[email protected]/src/testing/fuzz.go:724 +0xb9
created by testing.runFuzzTests in goroutine 1
/home/rafilx/go/pkg/mod/golang.org/[email protected]/src/testing/fuzz.go:527 +0x838
goroutine 42 [runnable]:
encoding/json.stateInStringEsc(0xc06c9f4388, 0x5c?)
/home/rafilx/go/pkg/mod/golang.org/[email protected]/src/encoding/json/scanner.go:353 +0x1a5
encoding/json.checkValid({0xc1bb52a000, 0x7ef6, 0x8?}, 0xc06c9f4388)
/home/rafilx/go/pkg/mod/golang.org/[email protected]/src/encoding/json/scanner.go:35 +0x9d
encoding/json.Unmarshal({0xc1bb52a000, 0x7ef6, 0x8000}, {0x30eaae0, 0xc0017af498})
/home/rafilx/go/pkg/mod/golang.org/[email protected]/src/encoding/json/decode.go:102 +0x54
github.com/cosmos/cosmos-sdk/types.TypedEventToEvent({0x5096970, 0xc06c1dd200})
/home/rafilx/go/pkg/mod/github.com/cosmos/[email protected]/types/events.go:97 +0xc5
github.com/cosmos/cosmos-sdk/types.(*EventManager).EmitTypedEvent(0xc001eb51a0, {0x5096970?, 0xc06c1dd200?})
/home/rafilx/go/pkg/mod/github.com/cosmos/[email protected]/types/events.go:64 +0x3d
github.com/babylonlabs-io/babylon/x/epoching.EndBlocker({0x50bed48, 0xc0021a7188}, {{0x50dd160, 0xc001200950}, {0x507b180, 0xc000fb01d8}, {0x50abcd0, 0xc000719878}, {0x5090f28, 0xc000778508}, ...})
/home/rafilx/projects/github.com/babylonlabs-io/babylon/x/epoching/abci.go:116 +0x9ee
…epoch-stk-msg-srvr
…abylon into rafilx/epoch-stk-msg-srvr
RafilxTenfen
added
the
consensus breaking
RafilxTenfen
commented
Jan 28, 2025
|
|
||
| // RegisterStakingQueryAndMigrations registrates in the configurator | ||
| // the x/staking query server and its migrations | ||
| func (app *BabylonApp) RegisterStakingQueryAndMigrations() { |
There was a problem hiding this comment.
We still need to register the staking migrations, so every new migration in https://github.com/cosmos/cosmos-sdk/blob/32969cf7cc602bb380f78dee23f0f0a747728791/x/staking/module.go#L141 we need to apply here as well
KonradStaniec
approved these changes
Jan 31, 2025
Lazar955
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x/stakingmsgs from routerx/stakingto epoch keeper to call the necessary functions directly instead of from the routerMsgWrappedEditValidatorandMsgWrappedStakingUpdateParamsto epoching txs so all the msgs from staking can be called even with the router removedx/stakingtx subcommand