docs: registration of phase 1 stake #417
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitsalis
reviewed
Jan 18, 2025
vitsalis
reviewed
Jan 21, 2025
vitsalis
reviewed
Jan 26, 2025
| The timelock period for unbonding, measured in Bitcoin blocks, indicating | ||
| how long funds remain locked. It should be an unsigned integer (uint32) and | ||
| ensure that any `unbonding_time` you choose is more than that specified | ||
| by the `min_unbonding_time_blocks` parameter in the genesis file. |
There was a problem hiding this comment.
It's not in the genesis file but in the Babylon parameters. Do you think that it makes to have a 3.2. Babylon chain BTC Staking parameters section which explains the parameters of the x/btcstaking module, what they mean, and how they can be retrieved? As a lot of this data relates to the Babylon parameters.
There was a problem hiding this comment.
yes I agree, I think that it would be more clear and we can just reference the params
| * Using our [TypeScript BTC staking library](https://github.com/babylonlabs-io/btc-staking-ts) | ||
| * Implementing the transaction generation themselves using the | ||
| [staking script specification](./staking-script.md) as a reference. | ||
| * `unbonding_value`: |
There was a problem hiding this comment.
Not sure I understand this parameter. I guess it refers to the unbonding fee, as I suppose that the staker can't set it to anything they want.
There was a problem hiding this comment.
you're right I got this one confused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.