Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync from main to base/consumer-chain-support #414

Closed
wants to merge 3 commits into from

Conversation

github-actions[bot]
Copy link

This PR synchronizes changes from main to base/consumer-chain-support.

- Improves nonce generation for adaptor signatures
- adds custom data for nonce generation
KonradStaniec and others added 2 commits January 16, 2025 07:50
- Each module need to be listed in the config to generate the data in
swagger
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Contributor

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Approving as AFAIK this doesn't impact the consumer integration functionality.

@@ -30,6 +30,23 @@
}
}
},
{
"url": "./tmp-swagger-gen/babylon/btcstaking/v1/query.swagger.json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Fix spacing?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Not sure why these are modified, as there are no proto changes in this PR.

@maurolacy
Copy link
Contributor

maurolacy commented Jan 21, 2025

This has to be solved manually. @SebastianElvis, it's OK if I merge and push this to base? Or perhaps it's better if you do it.

@SebastianElvis
Copy link
Member

Let's close this one and do the bump manually in a separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants