Skip to content

Commit

Permalink
chore: address PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
RafilxTenfen committed Jan 31, 2025
1 parent 3d78a36 commit 269401d
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 3 deletions.
16 changes: 13 additions & 3 deletions app/app_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,18 @@ func TestStakingRouterDisabled(t *testing.T) {
AppOpts: TmpAppOptions(),
})

msg := &stktypes.MsgCreateValidator{}
msgs := []sdk.Msg{
&stktypes.MsgCreateValidator{},
&stktypes.MsgBeginRedelegate{},
&stktypes.MsgCancelUnbondingDelegation{},
&stktypes.MsgDelegate{},
&stktypes.MsgEditValidator{},
&stktypes.MsgUndelegate{},
&stktypes.MsgUpdateParams{},
}

msgHandler := app.MsgServiceRouter().HandlerByTypeURL(sdk.MsgTypeURL(msg))
require.Nil(t, msgHandler)
for _, msg := range msgs {
msgHandler := app.MsgServiceRouter().HandlerByTypeURL(sdk.MsgTypeURL(msg))
require.Nil(t, msgHandler)
}
}
7 changes: 7 additions & 0 deletions x/epoching/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,13 @@ to a node it will error out. Since there is no message to be received
by the Staking module, all of commands under `babylond tx staking` were
removed.

**Staking module Migrations.** Since the staking module msg server
was not registered in the app routes, the function of staking `AppModule`
that register the migrations and the query server are in the
[`app.go`](https://github.com/babylonlabs-io/babylon/blob/cf6c0e3873133331d95267a58da06c04a3e2c601/app/app.go#L608). If a new
version of the cosmos-sdk is released and there is a new migration,
it is needed to register the migration there too.

**Delaying wrapped messages to the end of epochs.** The Epoching module
maintains a message queue for each epoch. Upon each wrapped message, the
Epoching module performs basic sanity checks, then enqueues the message to the
Expand Down

0 comments on commit 269401d

Please sign in to comment.