F/rewards distribution e2e 2

[maurolacy]

Tests the new version of rewards distribution / withdrawal.

[maurolacy]

Taking a look at CI failures. E2e tests are passing on my local btw.

[SebastianElvis]

Nice 👍

The local integration test failed though

[gusin13]

Maybe the staker_addr coming in local integration tests (make test-integration) is using bbnc prefix but the contract expects bbn

https://github.com/babylonlabs-io/babylon-contract/blob/e3552238cd619f99ab262594a2c62558b8b65042/packages/apis/src/lib.rs#L37-L38

[maurolacy]

Maybe the staker_addr coming in local integration tests (make test-integration) is using bbnc prefix but the contract expects bbn

Yes, this requires a fix of the datagen module on babylon. On it.

[SebastianElvis]

Faced the same issue at FP. For now I worked around by doing this. Not sure if touching Babylon for this fix is a good idea or not

[maurolacy]

Not sure if touching Babylon for this fix is a good idea or not

Too late 😉. Here's the PR: babylonlabs-io/babylon#513.

Regarding if it's a good idea or not, the changes are minimal, and fully backwards compatible. In any case, we shouldn't be using datagen in the Consumer's SDK if it's meant to be Babylon specific.

Perhaps datagen should migrate to its own babylon-datagen repo...