F/add local bcd #54
Merged
F/add local bcd #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianElvis
approved these changes
Oct 18, 2024
Makefile
Outdated
Comment on lines
23
to
24
| # A local bcd image with users and funds for testing / development / integration purposes | ||
| build-local-bcd: | ||
| $(DOCKER) build --tag babylonlabs-io/local-bcd -f contrib/images/local-bcd/Dockerfile . |
There was a problem hiding this comment.
Suggested change
| # A local bcd image with users and funds for testing / development / integration purposes | |
| build-local-bcd: | |
| $(DOCKER) build --tag babylonlabs-io/local-bcd -f contrib/images/local-bcd/Dockerfile . | |
| # A local bcd image with users and funds for testing / development / integration purposes | |
| build-bcd: | |
| $(DOCKER) build --tag babylonlabs-io/local-bcd -f contrib/images/local-bcd/Dockerfile . |
I would imagine we will be using this for local deployments as well
|
Also should this be pushed to |
I'll merge to |
Remove run / stop targets
maurolacy
force-pushed
the
f/add-local-bcd
branch
from
6da0bb6 to
910a568
Compare
maurolacy
added a commit
that referenced
this pull request
Oct 18, 2024
Adds local bcd instance docker image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a docker image with a local
bcdinstance for testing / integration purposes.