refactor: move ics23_commitment to a new package (#113)

Resolves #105

This PR moves the `ics23_commitment` folder out as a separate package,
so that other projects can import it as dependency.

cc @gregdhill

Cargo.toml

@@ -28,6 +28,7 @@ babylon-bitcoin = { path = "./packages/bitcoin" }
 babylon-btcstaking = { path = "./packages/btcstaking" }
 babylon-contract = { path = "./contracts/babylon" }
 eots = { path = "./packages/eots" }
+ics23-commitment = { path = "./packages/ics23_commitment" }
 anyhow = "1.0.82"
 bech32 = "0.9.1"
 bitcoin = "0.31.1"

contracts/babylon/Cargo.toml

@@ -36,6 +36,7 @@ babylon-apis     = { path = "../../packages/apis" }
 babylon-bindings = { path = "../../packages/bindings" }
 babylon-proto    = { path = "../../packages/proto" }
 babylon-bitcoin  = { path = "../../packages/bitcoin" }
+ics23-commitment = { path = "../../packages/ics23_commitment" }
 blst             = { workspace = true }
 cosmwasm-schema  = { workspace = true }
 cosmwasm-std     = { workspace = true }

contracts/babylon/src/utils/cosmos_store.rs

@@ -1,4 +1,4 @@
-use crate::utils::ics23_commitment::merkle::convert_tm_proto_to_ics_merkle_proof;
+use ics23_commitment::merkle::convert_tm_proto_to_ics_merkle_proof;
 
 // the below keys are hard-coded for now. They have to be consistent with the Babylon repo.
 // TODO: integration tests for ensuring they are the same, or parametrise them upon instantiation
@@ -43,7 +43,7 @@ pub fn verify_store(
         .map_err(|err|format!("failed to convert tendermint_proto::crypto::ProofOps to ibc::core::ics23_commitment::merkle::MerkleProof: {err:?}"))?;
 
     // construct values for verifying Merkle proofs
-    let specs = crate::utils::ics23_commitment::specs::ProofSpecs::default();
+    let specs = ics23_commitment::specs::ProofSpecs::default();
     let merkle_root = root.to_vec();
     let merkle_keys = vec![module_key.to_vec(), key.to_vec()];
 

contracts/babylon/src/utils/mod.rs

@@ -1,7 +1,6 @@
 mod bitcoin;
 mod bls;
 mod cosmos_store;
-mod ics23_commitment;
 
 pub mod babylon_epoch_chain;
 pub mod btc_light_client;

packages/ics23_commitment/Cargo.toml

@@ -0,0 +1,15 @@
+[package]
+name = "ics23-commitment"
+version.workspace = true
+edition.workspace = true
+license.workspace = true
+repository.workspace = true
+authors.workspace = true
+publish.workspace = true
+
+[dependencies]
+anyhow         = { workspace = true }
+ics23        = { workspace = true }
+prost        = { workspace = true }
+thiserror   = { workspace = true }
+tendermint-proto = { workspace = true }

contracts/babylon/src/utils/ics23_commitment/merkle.rs → packages/ics23_commitment/src/merkle.rs

@@ -1,5 +1,5 @@
-use crate::utils::ics23_commitment::error::CommitmentError;
-use crate::utils::ics23_commitment::specs::ProofSpecs;
+use crate::error::CommitmentError;
+use crate::specs::ProofSpecs;
 use ics23::commitment_proof::Proof;
 use ics23::{calculate_existence_root, verify_membership, CommitmentProof};