Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UT Cross Disciplinary 1 #65

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

michelangelo-acca
Copy link
Collaborator

Unit test

Test the interaction / interference with different domains spatial structures.

Covered topics

  • project setup
  • georeferencing
  • alignment semantics
  • alignment geometry
  • linear placement
  • project breakdown structure / spatial structure
  • terrain
  • triangulated irregular network
  • open cross profile
  • sectioned surface & solid
  • pavement & course
  • surface feature
  • earthworks
  • geotechnics
  • longitudinal products (barriers, guardrail, ...)
  • interchange
  • structural
  • drainage
  • signage
  • road furniture
  • rail furniture
  • ports & waterways furniture
  • bridge furniture

@pjanck
Copy link
Member

pjanck commented Mar 18, 2021

Can you please merge in the latest state of the main branch? We've updated the IFC schema checker to support RC3 files as well.

@AlexBrad1eyCT AlexBrad1eyCT added IFC4x3_RC3 IFC 4.3 RC3 content topic:earthworks Topic concerns Earthworks and removed topic:earthworks Topic concerns Earthworks labels Apr 20, 2021
Copy link
Collaborator

@AlexBrad1eyCT AlexBrad1eyCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firstly, thank you for the unit test and against this very new and alien concept to Infrastructure.

The file is Syntactically correct which is highlighted by the passing checks, but semantically there are a few issues around the organisation of the spatial hierarchy. we are trying to make sure the unit tests are simple representatives both in syntax and modelling practices so the advised changes are as follows:

  • ROADSEGMENT is logically not associated to a LATERAL IfcFacilityPart and more suitable value would be TRAFFICLANE;, which would make this model a 2 lane road.
  • longitudinal segments can be decomposed into lateral parts or vice versa but logically usually don't exist as a siblings in the hierarchy.
  • the conceptual organisation of the model is a bit perculiar as it is the road and railway both pass over the bridge (inferring they are side by side) then they intersect. would it be more understandable and to highlight the possible elements better by having one PassUnder then intersect further along??

once these are discussed and resolved we can merge this useful unit test!

CrossDisciplinary-1/UT-CrossDisciplinary-1.ifc Outdated Show resolved Hide resolved
CrossDisciplinary-1/UT-CrossDisciplinary-1.ifc Outdated Show resolved Hide resolved
CrossDisciplinary-1/UT-CrossDisciplinary-1.ifc Outdated Show resolved Hide resolved
Copy link
Collaborator

@AlexBrad1eyCT AlexBrad1eyCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only Issue:

  • IfcRelInterferesElement relationships are directional and currently backwards.

other than that LFTM.

Comment on lines 43 to 44
#36 = IFCRELINTERFERESELEMENTS('1KGxl_MJzCugAzAbkkkI95', #1, $, $, #33, #26, $, 'PassesOver', .U.);
#37 = IFCRELINTERFERESELEMENTS('258z1l3OLB2AfN2jNMLr8D', #1, $, $, #33, #30, $, 'PassesUnder', .U.);
Copy link
Collaborator

@AlexBrad1eyCT AlexBrad1eyCT Jun 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the developing Documentation around IfcRelInterferesElements PassesOver and PassesUnder is directional in nature so it should be as below.

  • PassesOver: the RelatingElement is passing over the RelatedElement (e.g a bridge passing over a water canal)
  • PassesUnder: the RelatingElement is passing under the RelatedElement (e.g a Pipe passing under a road)

therefore your relationships are currently backwards (e.g. Bridge passesOver Road... :P)

link to developing docs: IfcRelInterferesElements Documentation

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okkk! Let's see if I got this right!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IFC4x3_RC3 IFC 4.3 RC3 content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants