Georeferencing-Survey-12d-3 #112
Conversation
A survey string with properties for the entire string, properties for each vertex and properties for each segment.
took out an _
| However I have no idea how these prperties can be represented in IFC. | ||
| So as a start I have mapped the Property set for the vertices and segments to Property Sets for IfcAnnotation with: | ||
|
|
||
| - Property sets with properties for the entire string | ||
| - Property set Vertex with the properties for each vertex with the property name for a vertex appended by the number for the vertex (starting at 1) | ||
| - Property set Segment with the properties for each segment with the property name for a segment appended by the number for the segment (starting at 1) |
There was a problem hiding this comment.
Proposal:
I'd introduce an IfcAnnotation for each individual point, assign the corresponding IfcCartesianPoint as its geometric representation, and assign the corresponding PropSet for each individually.
You can also make use of the IfcRoot.Name attribute (part of the IfcAnnotation) for naming of points / string lines, etc.
NOTE I'd except this text to be part of the pull request in order to discuss in the pull request, not as part of the "finalized" Readme :)
There was a problem hiding this comment.
What about the geometry of the segment between each vertex ?
And the Property Sets that go with each segment ?
There was a problem hiding this comment.
That would be another IfcAnnotation with its own geometry (line?) and properties.
There was a problem hiding this comment.
A new unit test Georeferencing-Survey-12d-4 as been added with such an alternate structure for the survey string line with string line property sets, vertex property sets and segment property sets.
| - `IfcPropertySetSingleValue` with `IfcPropertySetSingleValue.Nominalvalue` IFCLABEL | ||
| - `IfcPropertySetSingleValue` with `IfcPropertySetSingleValue.Nominalvalue` IFCREAL |
There was a problem hiding this comment.
What's a IfcPropertySetSingleValue?
There was a problem hiding this comment.
the readme.md has now been updated to change IfcPropertySetSingleValue to IfcPropertySingleValue
Unit test
A survey string with properties for the entire string, properties for each vertex and properties for each segment.
Covered topics
tick one/many