Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IFC4.3-dev property changes reconciliation #394

Open
wants to merge 29 commits into
base: develop
Choose a base branch
from

Conversation

aothms
Copy link
Collaborator

@aothms aothms commented Apr 15, 2022

This is a regeneration of all Pset Qto Properties PropertyConstants PropertyEnumerations Quantities XML definitions from the 4.3 dev repo. For reconciliation to have a unified basis for deployment project of tunnel.

Approach:

  • Looked up pset, penum and constant UniqueIds by name
  • Looked up property UniqueId based on < prop type, prop value type(s), definition >
  • New property UniqueId deterministically generated based on uuid 5 with < prop type, prop value type(s), definition >

Complexity:

  • As you might be aware, the 4.3 dev repo stores property definitions as (a) a definition (b) a pset-specific comment. I have merged these back into a single definition separated by a HTML comment so that when importing back we can hopefully maintain this distinction.
  • There are no localization definitions. Not sure what the plan is with these, I think we have better alternatives like bsDD and Crowdin, as they are hard to maintain in XML, but we can't discard them unless we know they are migrated away properly to a new system.
  • Unfortunately, diffs aren't very minimal because of inconsistencies in whitespace /> vs /> and inconsistencies in hex/base64 unique id formatting within the original version.
  • Due to lack of branching and due to new commits that have came in, it's not very clear where to branch off of and merge into.

Issues:

  • HTML generation doesn't fully succeed on the changes, but I don't get any stacktrace on DocLite. It seems psd xml et al. are generated but the html for the schemas are missing bits. Hope to receive some clues. It's probably a minor thing.

AlexBrad1eyCT and others added 29 commits December 21, 2021 17:24
Fixing missing Type Applicabilities and propertySet Typings
@pjanck pjanck added the Legacy Issues stemming from before 2023.01.01. label Mar 15, 2023
@pjanck pjanck added the reconcile Reconciliation conten with 4.3.2.0 label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Legacy Issues stemming from before 2023.01.01. reconcile Reconciliation conten with 4.3.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants