Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for alpha channel and bug fix #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KishorJena
Copy link

@KishorJena KishorJena commented Jan 5, 2023

This commit adds support for the alpha channel and fixes issues

This commit adds support for the alpha channel and fixes issues such as ICCP, ALPH chunks, and reading VP8L data. Also fixed code where VP8X flags were being read incorrectly.
@KishorJena KishorJena changed the title Support for alpha channel, bug fix Support for alpha channel and bug fix Jan 5, 2023
@Luosoha
Copy link

Luosoha commented Jan 21, 2024

This commit adds support for the alpha channel and fixes issues

Hi, I'm using these changes that you made but still receive the error "Not supported FourCC: ??.V.P.8.".
I found out I got the exception when the fcc array is [0], 'V', 'P', '8' (the first is null character)
Could you please help me?

@KishorJena
Copy link
Author

This commit adds support for the alpha channel and fixes issues

Hi, I'm using these changes that you made but still receive the error "Not supported FourCC: ??.V.P.8.". I found out I got the exception when the fcc array is [0], 'V', 'P', '8' (the first is null character) Could you please help me?

Hi @Luosoha , Yeah I am aware of that issue and already fixed in my local repo. I think odd/even length is not handled in this PR.
Can you share the webp image here.

@Luosoha
Copy link

Luosoha commented Jan 22, 2024

This commit adds support for the alpha channel and fixes issues

Hi, I'm using these changes that you made but still receive the error "Not supported FourCC: ??.V.P.8.". I found out I got the exception when the fcc array is [0], 'V', 'P', '8' (the first is null character) Could you please help me?

Hi @Luosoha , Yeah I am aware of that issue and already fixed in my local repo. I think odd/even length is not handled in this PR. Can you share the webp image here.

It happens when I add a bitmap with transparent pixels (in my case, I am drawing an image to a canvas and the image has a smaller size than the canvas) to the encoder.

@KishorJena
Copy link
Author

KishorJena commented Jan 22, 2024

This commit adds support for the alpha channel and fixes issues

Hi, I'm using these changes that you made but still receive the error "Not supported FourCC: ??.V.P.8.". I found out I got the exception when the fcc array is [0], 'V', 'P', '8' (the first is null character) Could you please help me?

Hi @Luosoha , Yeah I am aware of that issue and already fixed in my local repo. I think odd/even length is not handled in this PR. Can you share the webp image here.

It happens when I add a bitmap with transparent pixels (in my case, I am drawing an image to a canvas and the image has a smaller size than the canvas) to the encoder.

We need a base canvas with height, width stored in global chunk VP8X.
I think in this PR i have not used that maybe. I have to read the codes again.

I have made separate lib out of this which uses global canvas height width of animation rather frame specfic height width and to properly aligning it we use frame's x,y info. I have not made it public yet due to naming issue.

You can connect me on email or social media so that i can share that with you. you can try and tell me problem still persist

@Luosoha
Copy link

Luosoha commented Jan 23, 2024

This commit adds support for the alpha channel and fixes issues

Hi, I'm using these changes that you made but still receive the error "Not supported FourCC: ??.V.P.8.". I found out I got the exception when the fcc array is [0], 'V', 'P', '8' (the first is null character) Could you please help me?

Hi @Luosoha , Yeah I am aware of that issue and already fixed in my local repo. I think odd/even length is not handled in this PR. Can you share the webp image here.

It happens when I add a bitmap with transparent pixels (in my case, I am drawing an image to a canvas and the image has a smaller size than the canvas) to the encoder.

We need a base canvas with height, width stored in global chunk VP8X. I think in this PR i have not used that maybe. I have to read the codes again.

I have made separate lib out of this which uses global canvas height width of animation rather frame specfic height width and to properly aligning it we use frame's x,y info. I have not made it public yet due to naming issue.

You can connect me on email or social media so that i can share that with you. you can try and tell me problem still persist

I messaged you to [email protected] :D

@KishorJena
Copy link
Author

OK i just noticed that I can share the info here as well.
README.md

@Luosoha
Copy link

Luosoha commented Jan 25, 2024 via email

@Luosoha
Copy link

Luosoha commented Jan 25, 2024 via email

@KishorJena
Copy link
Author

It seems I can't download your lib at all, everytime I sync the project it shown that it downloads the lib again. Vào Th 5, 25 thg 1, 2024 vào lúc 10:17 Sơn Hải Lương < @.> đã viết:

Hi, I imported your lib to my gradle but I can't seem to call any of your classes in my code. Do you know what could go wrong here? Vào Th 3, 23 thg 1, 2024 vào lúc 14:29 Kishor Jena < @.
> đã viết: > OK i just noticed that I can share the info here as well. > README.md > https://github.com/b4rtaz/android-webp-encoder/files/14019808/README.md > > — > Reply to this email directly, view it on GitHub > <#5 (comment)>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/AE7YDS6ZYF6OBAMS4EHTJPDYP5RFTAVCNFSM6AAAAAATR5H5VOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBVGQ2DIMRYGY > . > You are receiving this because you were mentioned.Message ID: > @.***> >

maybe due to private repo or something i have to look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants