Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: precompiled contract poc #171

Closed

Conversation

dudong2
Copy link

@dudong2 dudong2 commented Aug 26, 2024

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@dudong2 dudong2 changed the base branch from basechain/v0.45.16 to basechain/abci1.0/delevelop August 31, 2024 05:33
@dudong2 dudong2 marked this pull request as ready for review August 31, 2024 05:33
@dudong2 dudong2 self-assigned this Aug 31, 2024
@dudong2 dudong2 requested a review from jasonsong0 September 2, 2024 02:28
@dongsam dongsam deleted the branch basechain/abci1.0/delevelop September 4, 2024 03:36
@dongsam dongsam closed this Sep 4, 2024
@dongsam
Copy link
Member

dongsam commented Sep 4, 2024

@dudong2 Oops, there was a typo in basechain/abci1.0/delevelop, so I removed it and created a new branch under basechain/abci1.0/develop, which caused the PR to close. Could you kindly create a new PR based on the new branch? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants