Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the rules call
getPackages
fromget-monorepo-packages
many times per execution, even whendirectory
is the same (which I'd imagine it always is?). So just adding a module-level cache here saves us some work.This isn't a huge time saving, but experimentally in a large monorepo I saw it shave off ~30s of total time on a ~2m run, which is non-negligible.
This PR assumes that it's safe to do this: if it's not safe, due to something I've overlooked, the alternative (better) approach is probably to add a config option allowing users to pass in a list of monorepo paths, so it doesn't need to be calculated at all by the plugin. Though if this is fine then it's less work since it doesn't require a new config option + documentation etc.