Add trusted proxies #385
Open
Add trusted proxies #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azukaar
reviewed
Jan 26, 2025
| @@ -174,6 +174,8 @@ | |||
| "mgmt.config.http.hostnameInput.HostnameLabel": "Nom d'hôte : Cela sera utilisé pour restreindre l'accès à votre serveur Cosmos (Votre IP, ou votre nom de domaine)", | |||
| "mgmt.config.http.hostnameInput.HostnameValidation": "Le nom d'hôte est obligatoire", | |||
| "mgmt.config.http.publishMDNSCheckbox": "Cela vous permet de publier votre serveur sur votre réseau local en utilisant mDNS. Cela signifie que tous vos domaines .local seront disponibles sur votre réseau local sans configuration supplémentaire.", | |||
| "mgmt.config.http.trustedProxiesInput.trustedProxiesLabel": "Trusted proxies allow X-Forwarded-For from IP/IP range.", | |||
| "mgmt.config.http.trustedProxiesInput.trustedProxiesHelperText": "Use this setting when you have an upstream proxy server to avoid it being blocked by Shield. IPs or IP ranges separated by commas.", | |||
There was a problem hiding this comment.
You added english into the french file :p
There was a problem hiding this comment.
Should be good now !
This reverts commit 4a4f526.
Remove unwanted edition of last line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add trusted proxies
This pull request adds a parameter allowing the specification of a list of trusted proxies for which the X-Forwarded-For header will be used. This enhances security and management of IP addresses from trusted proxies.
Changes Made:
client/src/pages/config/users/configman.jsx :
client/src/utils/locales/en/translation.json :
client/src/utils/locales/fr/translation.json :
src/httpServer.go :
src/proxy/shield.go :
src/utils/middleware.go :
src/utils/types.go :
src/utils/utils.go :
Note
I accidentally deleted PR #339, so here we go again