-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding roverlight and Symphony deprecation #406
base: main
Are you sure you want to change the base?
Conversation
- Added roverlight variant with optimized Docker builds - Removed Symphony integration and related scripts - Updated documentation for standard Terraform workspace structure - Added multi-platform support (AMD64/ARM64) - Enabled Docker layer caching for improved performance Co-Authored-By: Arnaud Lheureux <[email protected]>
- Added Dockerfile.roverlight for multi-platform builds - Added GitHub Actions workflows for builds and security - Added ROVERLIGHT.md documentation Co-Authored-By: Arnaud Lheureux <[email protected]>
Co-Authored-By: Arnaud Lheureux <[email protected]>
Co-Authored-By: Arnaud Lheureux <[email protected]>
Co-Authored-By: Arnaud Lheureux <[email protected]>
Co-Authored-By: Arnaud Lheureux <[email protected]>
Co-Authored-By: Arnaud Lheureux <[email protected]>
Co-Authored-By: Arnaud Lheureux <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This pull request updates the development container configuration and GitHub workflows to support a new lightweight version of the rover container (Roverlight) while deprecating Symphony configurations. Key changes include:
- Addition of dedicated GitHub workflows for building, releasing, and security scanning Roverlight images.
- Updates to the devcontainer, Dockerfile, and documentation to clearly differentiate between the standard and light container variants.
- Enhancements in the dependabot configuration and cache upgrade for improved CI efficiency.
Reviewed Changes
File | Description |
---|---|
.github/workflows/roverlight-build.yml | New workflow for building and releasing Roverlight images with caching and scanning support. |
.github/workflows/roverlight-security-scan.yml | New workflow for security scanning of Roverlight images. |
docs/ROVERLIGHT.md | Documentation outlining the features and usage of the Roverlight container. |
README.md | Updated badges and description to include references to both standard and light variants. |
.github/dependabot.yml | Added devcontainers package ecosystem with daily update schedule. |
docs/DEV_CONTAINER.md | Updated details to reflect the two available variants of the development container. |
.github/workflows/rover.yml | Updated Docker layer caching to v3 for improved performance. |
docs/USAGE.md | Revised usage documentation, removing outdated CI/CD references. |
docs/CONTINOUS_INTEGRATION.md | Removed obsolete CI integration documentation. |
Copilot reviewed 31 out of 31 changed files in this pull request and generated no comments.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
…config Co-Authored-By: Arnaud Lheureux <[email protected]>
Co-Authored-By: Arnaud Lheureux <[email protected]>
b7f8a73
to
dfaa762
Compare
Co-Authored-By: Arnaud Lheureux <[email protected]>
Co-Authored-By: Arnaud Lheureux <[email protected]>
Co-Authored-By: Arnaud Lheureux <[email protected]>
Co-Authored-By: Arnaud Lheureux <[email protected]>
Co-Authored-By: Arnaud Lheureux <[email protected]>
…uilds Co-Authored-By: Arnaud Lheureux <[email protected]>
Co-Authored-By: Arnaud Lheureux <[email protected]>
Co-Authored-By: Arnaud Lheureux <[email protected]>
Co-Authored-By: Arnaud Lheureux <[email protected]>
… scan Co-Authored-By: Arnaud Lheureux <[email protected]>
This pull request includes significant updates to the development container setup, workflow configurations, and Dockerfile improvements. The most important changes include replacing Docker Compose with a single Dockerfile, updating the devcontainer configuration, and adding new GitHub workflows for building and scanning containers.
Development Container Updates:
.devcontainer/Dockerfile
: Removed the Dockerfile used for Docker Compose setup..devcontainer/devcontainer.json
: Updated the configuration to use a new base image, added volume mounts, run arguments, and features for the development container.Workflow Configuration Changes:
.github/workflows/rover-preview.yml
: Removed the workflow for building Rover preview images..github/workflows/rover.yml
: Updated the workflow to use a new cache action version..github/workflows/roverlight-build.yml
: Added a new workflow for building and releasing Roverlight images with caching and security scanning steps..github/workflows/roverlight-security-scan.yml
: Added a new workflow for security scanning of Roverlight images.Dockerfile Improvements:
Dockerfile
: Refactored the Dockerfile to streamline ARG and ENV declarations, updated package installations, and added new repositories and keys for dependencies. [1] [2]Dependabot Configuration:
.github/dependabot.yml
: Added a new package-ecosystem for devcontainers with a daily update schedule.