Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how-to-test-db-only-changes.md #990

Conversation

alecsci
Copy link
Member

@alecsci alecsci commented Aug 26, 2024

Adjust docs when testing only db changes for Docker setup

Description

  • Using docker down / up only restarts the compilation of files, not the state of DB which is persisted on the volume
  • 90% of the scripts required for testers / triagers are ran against acore_world

Notes

  • For spanish, I will use DeepL if you approve the current description

Adjust docs when testing only db changes for Docker setup
@Helias Helias merged commit d018755 into azerothcore:master Aug 26, 2024
1 check passed
@Helias
Copy link
Member

Helias commented Aug 26, 2024

I think that the docker-compose down does not destroy the volumes which is what keep the same acore_world version
your update should be correct indeed, thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants