Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced Config Handling, New Category, and Vanilla Dungeon Support #40

Closed
wants to merge 8 commits into from
Closed

Enhanced Config Handling, New Category, and Vanilla Dungeon Support #40

wants to merge 8 commits into from

Conversation

blkht01
Copy link

@blkht01 blkht01 commented May 29, 2024

  • Config Value Handling: Reversed the logic for the InNormalDungeons configuration value.
  • New Category: Introduced a new category named "Other" for miscellaneous items such as mounts, currencies, and more.
  • Vanilla Dungeons: Added support for Gnomeregan and Razorfen Kraul (RFK).

blkht01 added 3 commits May 30, 2024 01:05
@blkht01
Update handling of config value for InNormalDungeons
22bb77a 
Inverse the handling of config value InNormalDungeons
Added new category: "Other" for stuff like mounts, currencies, etc..
Added Gnomeregan and RFK
@blkht01
Update handling of config value for InNormalDungeons
b11afeb 
Inverse the handling of config value InNormalDungeons
Added new category: "Other" for stuff like mounts, currencies, etc..
Added Gnomeregan and RFK
@blkht01
Comment LOG_INFO
7c3e658
55Honey
55Honey requested changes Jun 1, 2024
View reviewed changes
Copy link
Member

@55Honey 55Honey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please note that content which requires further changes than this module provides, can not be accepted into the default setup.

src/mod_zone_difficulty_scripts.cpp Outdated Show resolved Hide resolved
src/mod_zone_difficulty_scripts.cpp Outdated Show resolved Hide resolved
src/mod_zone_difficulty_scripts.cpp Outdated Show resolved Hide resolved
src/mod_zone_difficulty_scripts.cpp Show resolved Hide resolved
src/mod_zone_difficulty_handler.cpp Outdated Show resolved Hide resolved
@blkht01
Copy link
Author

blkht01 commented Jun 4, 2024

I've gone through your requests and commited my changes. Please verify, thanks.

@blkht01 blkht01 requested a review from 55Honey June 10, 2024 22:04
@55Honey 55Honey requested a review from Nyeriah June 15, 2024 11:52
@blkht01 blkht01 requested review from 55Honey and Nyeriah June 23, 2024 00:59
@blkht01 blkht01 closed this Jul 1, 2024
@blkht01
Copy link
Author

blkht01 commented Jul 1, 2024

Closing because nothing is happening here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@55Honey 55Honey Awaiting requested review from 55Honey

@Nyeriah Nyeriah Awaiting requested review from Nyeriah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blkht01 @Nyeriah @55Honey @tarawow