forked from mindsear/TemplateNPC-azerothcore
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gossip handling to store data in database and add new features #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
identifiable module from table `updates`
use GetEntry() instead
its in the title of the npc and should be obvious from icons allows bottom icons to be visible
rename "DeathKnight" to "Death Knight" according to enum defines do not catch out of range exception, this should never happen
remove the hack, should be fixed soon^tm in core
- Integer display width is deprecated and will be removed in a future release. - 'utf8' is currently an alias for the character set UTF8MB3, but will be an alias for UTF8MB4 in a future release. Please consider using UTF8MB4 in order to be unambiguous. */
remove tokenize enum name renames reorganize sql update cfg
if empty these use base name
fixes the error below, hopefully > Player(GUID: 33 Name: Zulaman)::_SaveInventory - the bag(255) and slot(17) values for the item (GUID Full: 0x40000000000008c9 Type: Item Low: 2249) are incorrect, the item (GUID Full: 0x40000000000008da Type: Item Low: 2266) is there instead!
can player be null here?
This reverts commit d948348.
more thread-safe
Helias
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
Update the gossip system to store data in the database instead of 2 large switch statements.
Add an index table that holds the hello gossip entries and specifies the action, allows configurable options for hello gossip such as setting an icon, description, level range, and mask (gear/talents/glyphs). Additionally, it allows re-usable talents/glyphs by specifying overrides.
Reduce the number of gear tables to one by using a race mask to handle human/horde/alliance gear.
Add an administrator command to create templates by exporting a character's talents, gear, and glyphs to the database.
Add lvl 70 T6 templates
Add instructions on how to add templates to the README. I wrote a tool, to help create templates, that generates GM commands from a wowsims config
Changes details:
Issues Addressed:
SOURCE:
Tests Performed:
1 of each class
How to Test the Changes:
TODO / Issues:
areatrigger fmt shows as "{} {}"