Refactor, fix minor issues, add config #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
identifiable module from table `updates`
use GetEntry() instead
its in the title of the npc and should be obvious from icons allows bottom icons to be visible
rename "DeathKnight" to "Death Knight" according to enum defines do not catch out of range exception, this should never happen
|
build is failing for the codestyle check, fix it and I will merge the PR |
use destroyitem to destroy items occurs when trying to delete while wearing an empty head slot, segfaults SetUInt64Value(ITEM_FIELD_CONTAINED...
|
thanks for the PR 🚀 |
sogladev
added a commit
to sogladev/mod-npc-talent-template
that referenced
this pull request
Oct 27, 2024
* refactor: sql style to match acore standards * fix: typo Ballance to Balance * refactor: rename generic sql names to specific module identifiable module from table `updates` * refactor: remove not needed headers * feat: re-enable gear destroy, gyph reset, talent reset TODO: config * fix: typo successfully * refactor: remove gossiphello comment * fix: typo? npc entry to 55009 * refactor: use define instead of hardcoded npc entry * change icon of destroy gear, re-order menu * fixup! refactor: use define instead of hardcoded npc entry use GetEntry() instead * change reset talents icon to engi wheel * remove redundant "select your spec" from gossip its in the title of the npc and should be obvious from icons allows bottom icons to be visible * feat: add config to enable/disable additional gossip options * use EnumUtils to convert class to string rename "DeathKnight" to "Death Knight" according to enum defines do not catch out of range exception, this should never happen * fixup! feat: re-enable gear destroy, gyph reset, talent reset pet talents * fix crash when destroying items use destroyitem to destroy items occurs when trying to delete while wearing an empty head slot, segfaults SetUInt64Value(ITEM_FIELD_CONTAINED... * codestyle: remove extra empty line feat: re-enable gear destroy, gyph reset, talent reset TODO: config refactor: use define instead of hardcoded npc entry use GetEntry() instead feat: add config to enable/disable additional gossip options pet talents learn highest rank remove the hack, should be fixed soon^tm in core WIP commands export for 1 class+spec done extend export for all specs use racemask for gear instead of human, alliance, horde allow loading of generic index update for mysql v8.0 - Integer display width is deprecated and will be removed in a future release. - 'utf8' is currently an alias for the character set UTF8MB3, but will be an alias for UTF8MB4 in a future release. Please consider using UTF8MB4 in order to be unambiguous. */ modernize, use enum for gear/talent flag add copy cmd skeleton use generic ApplyTemplate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
npc_textcorrectly, there was a mismatch in entries in SQL and cppacore_stringif available, adds some localization support. Areatrigger broken fmt, so did not replace custom texts SendAreaTriggerMessage not fmt formatted azerothcore-wotlk#20006Issues Addressed:
SOURCE:
Tests Performed:
How to Test the Changes:
lvl 80 character
.npc add temp 55009issues / TODOs
.reset talents %tworks fine