Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features(Lualib/Lua(Jit)): Lua Version and Static Linking Support #209

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

iThorgrim
Copy link

@iThorgrim iThorgrim commented Jan 9, 2025

Eluna Module Updates: Lua Version and Static Linking Support

Recent updates to the Eluna module in AzerothCore introduce new configuration options to manage Lua versions and static linking:

  • -DLUA_VERSION=luajit/lua52/lua53/lua54: Select the Lua version for the module, supporting LuaJIT, Lua 5.2, 5.3, or 5.4.
  • -DLUA_STATIC=on/off: Configure whether Lua should be linked statically or dynamically.

These options allow flexible Lua integration, building on Eluna's existing capabilities to handle different Lua versions. The changes also improve compatibility and performance by enabling static linking where needed.

Integration with Eluna

This functionality extends Eluna's existing support for Lua compatibility, mainly in ElunaCompat.cpp, which handles Lua version-specific interactions. These updates enhance Eluna’s adaptability for various Lua configurations in AzerothCore.

For testing you need to test with this PR : azerothcore/azerothcore-wotlk#21123

Eluna Commit (ref): ElunaLuaEngine/ElunaTrinityWotlk@284673b

### Eluna Module Updates: Lua Version and Static Linking Support

Recent updates to the **Eluna** module in **AzerothCore** introduce new configuration options to manage Lua versions and static linking:

- **`-DLUA_VERSION=luajit/lua52/lua53/lua54`**: Select the Lua version for the module, supporting LuaJIT, Lua 5.2, 5.3, or 5.4.
- **`-DLUA_STATIC=on/off`**: Configure whether Lua should be linked statically or dynamically.

These options allow flexible Lua integration, building on Eluna's existing capabilities to handle different Lua versions. The changes also improve compatibility and performance by enabling static linking where needed.

#### Integration with Eluna

This functionality extends Eluna's existing support for Lua compatibility, mainly in **ElunaCompat.cpp**, which handles Lua version-specific interactions. These updates enhance Eluna’s adaptability for various Lua configurations in **AzerothCore**.
@55Honey
Copy link
Member

55Honey commented Jan 9, 2025

Thanks for the PR!
Is there a list of commits from eluna master which are covered by this?

@iThorgrim
Copy link
Author

Here's the main commit that adds this functionality to Eluna :

@Nyeriah Nyeriah merged commit f9fc165 into azerothcore:master Jan 12, 2025
1 check failed
@kissingers
Copy link

but why at linux bulid add these source file to game out put DIR?
image

@iThorgrim
Copy link
Author

Because these are the files required for Lua.

but why at linux bulid add these source file to game out put DIR? image

Because these are the files required for Lua.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants